Skip to content

Commit 719aebd

Browse files
committed
feeback Comments on library.
1 parent a9c0675 commit 719aebd

File tree

1 file changed

+41
-9
lines changed

1 file changed

+41
-9
lines changed

adafruit_tmp117.py

Lines changed: 41 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def initialize(self):
149149
def temperature(self):
150150
"""The current measured temperature in degrees Celsius"""
151151

152-
return self._read_temperature()
152+
return self._raw_temperature * _TMP117_RESOLUTION
153153

154154
@property
155155
def temperature_offset(self):
@@ -260,6 +260,17 @@ def averaged_measurements(self):
260260
261261
tmp117 = adafruit_tmp117.TMP117(i2c)
262262
263+
In order to print information in a nicer way we create a dictionary with the
264+
sensor information for the averaged measurements.
265+
266+
.. code-block::python3
267+
268+
Average_Measure = {1: "AVERAGE_1X", 2: "AVERAGE_8X", 3: "AVERAGE_32X", 4: "AVERAGE_64X"}
269+
270+
We print the information for the Temperature sensor
271+
272+
.. code-block::python3
273+
263274
# uncomment different options below to see how it affects the reported temperature
264275
# tmp117.averaged_measurements = adafruit_tmp117.AVERAGE_1X
265276
# tmp117.averaged_measurements = adafruit_tmp117.AVERAGE_8X
@@ -268,7 +279,7 @@ def averaged_measurements(self):
268279
269280
print(
270281
"Number of averaged samples per measurement:",
271-
tmp117.averaged_measurements,
282+
Average_Measure[tmp117.averaged_measurements],
272283
)
273284
print("")
274285
@@ -282,7 +293,7 @@ def averaged_measurements(self):
282293
@averaged_measurements.setter
283294
def averaged_measurements(self, value: int):
284295
if value not in [0, 1, 2, 3]:
285-
raise ValueError("averaged_measurements must be 0, 1, 2 or 3")
296+
raise ValueError("averaged_measurements must be set to 0, 1, 2 or 3")
286297
self._raw_averaged_measurements = value
287298

288299
@property
@@ -349,6 +360,26 @@ def measurement_delay(self):
349360
350361
tmp117 = adafruit_tmp117.TMP117(i2c)
351362
363+
In order to print information in a nicer way, we create a dictionary with the
364+
sensor information for the measurement delay.
365+
366+
.. code-block::python3
367+
368+
Delay_times = {
369+
0: "DELAY_0_0015_S",
370+
1: "DELAY_0_125_S",
371+
2: "DELAY_0_250_S",
372+
3: "DELAY_0_500_S",
373+
4: "DELAY_1_S",
374+
5: "DELAY_4_S",
375+
6: "DELAY_8_S",
376+
7: "DELAY_16_S",
377+
}
378+
379+
We print the information for the Temperature sensor
380+
381+
.. code-block::python3
382+
352383
# uncomment different options below to see how it affects the reported temperature
353384
354385
# tmp117.measurement_delay = adafruit_tmp117.DELAY_0_0015_S
@@ -361,7 +392,7 @@ def measurement_delay(self):
361392
# tmp117.measurement_delay = adafruit_tmp117.DELAY_16_S
362393
363394
print("Minimum time between measurements:",
364-
tmp117.measurement_delay)
395+
Delay_times[tmp117.measurement_delay])
365396
366397
print("")
367398
@@ -375,6 +406,10 @@ def measurement_delay(self):
375406

376407
@measurement_delay.setter
377408
def measurement_delay(self, value: int) -> None:
409+
if value not in [0, 1, 2, 3, 4, 5, 6, 7]:
410+
raise ValueError(
411+
"averaged_measurements must be set to 0, 1, 2, 3, 4, 5, 6, 7"
412+
)
378413
self._raw_measurement_delay = value
379414

380415
def take_single_measurement(self) -> float:
@@ -416,7 +451,7 @@ def alert_mode(self, value: Literal[ALERT_WINDOW, ALERT_HYSTERESIS]):
416451
417452
"""
418453
if value not in [0, 1]:
419-
raise ValueError("alert_mode must be an 0 or 1")
454+
raise ValueError("alert_mode must be set to 0 or 1")
420455
self._raw_alert_mode = value
421456

422457
@property
@@ -451,7 +486,7 @@ def _set_mode_and_wait_for_measurement(self, mode: int) -> float:
451486
while not self._read_status()[2]:
452487
time.sleep(0.001)
453488

454-
return self._read_temperature()
489+
return self._raw_temperature * _TMP117_RESOLUTION
455490

456491
# eeprom write enable to set defaults for limits and config
457492
# requires context manager or something to perform a general call reset
@@ -466,9 +501,6 @@ def _read_status(self) -> Tuple[int, int, int]:
466501

467502
return (high_alert, low_alert, data_ready)
468503

469-
def _read_temperature(self) -> float:
470-
return self._raw_temperature * _TMP117_RESOLUTION
471-
472504
# pylint: disable=no-self-use
473505
@staticmethod
474506
def _scaled_limit(value: float) -> int:

0 commit comments

Comments
 (0)