Skip to content

Update simpleio.tone() to work with nRF52840 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Sep 11, 2019 · 0 comments · Fixed by #46
Closed

Update simpleio.tone() to work with nRF52840 #45

kattni opened this issue Sep 11, 2019 · 0 comments · Fixed by #46
Assignees

Comments

@kattni
Copy link
Contributor

kattni commented Sep 11, 2019

At the moment, when attempting to use simpleio.tone() on the nRF52840 (Circuit Playground Bluefruit specifically), it fails with audioio not defined on line 68 in simpleio.py.

simpleio.tone() uses audioio.RawSample. CircuitPython now uses audiocore.RawSample. As well, the nRF52840 specifically uses audiopwmio.PWMAudioOut instead of audioio.AudioOut.

There is currently a check for CircuitPython 3.0 or higher in simpleio.tone() that includes 2.x backwards compatibility. My suggestion is to remove the 2.x code and then update simpleio.tone() to sort out the nRF vs the ATSAMD code. I don't know the status of audiocore in CircuitPython 4.x, so there may still need to be a version check.

Please let me know if you need any further information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants