From b8e327a92dc7bd68f0c68f964b3bc9441f2f05f2 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Sat, 11 Feb 2023 20:24:03 +0000 Subject: [PATCH 1/9] Update ssd1680_simpletest.py Added comment on setting for MonoChrome version . --- examples/ssd1680_simpletest.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/ssd1680_simpletest.py b/examples/ssd1680_simpletest.py index 48a4d4d..36c8c44 100644 --- a/examples/ssd1680_simpletest.py +++ b/examples/ssd1680_simpletest.py @@ -9,6 +9,11 @@ * https://www.adafruit.com/product/4947 * Adafruit 2.13" Tri-Color eInk Display FeatherWing * https://www.adafruit.com/product/4814 + +To use Adafruit 2.13" Monochrome FeatherWing - 250x122 Monochrome with SSD1680: + * https://www.adafruit.com/product/4195 + Set change height in display from 122 to 128 + """ import time From 68ba28bce25b880e0e9597b1010fa6e5e9bd8340 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Sat, 11 Feb 2023 20:28:53 +0000 Subject: [PATCH 2/9] Update ssd1680_simpletest.py --- examples/ssd1680_simpletest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ssd1680_simpletest.py b/examples/ssd1680_simpletest.py index 36c8c44..a8642e7 100644 --- a/examples/ssd1680_simpletest.py +++ b/examples/ssd1680_simpletest.py @@ -12,7 +12,7 @@ To use Adafruit 2.13" Monochrome FeatherWing - 250x122 Monochrome with SSD1680: * https://www.adafruit.com/product/4195 - Set change height in display from 122 to 128 + Set change height in display from 122 to 127 """ From e181b0ac6ee491eb5b8b0274b5e2bea093bb5cf4 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 20:20:48 +0000 Subject: [PATCH 3/9] Adjust colstart to support top/bottom row correction Added column_corection argument to ssd1680 to set colstart so can be adjusted in simpletest to fix issue #10 and can still work with previous sampletest file if needed as only tested on ESP32-S2. --- adafruit_ssd1680.py | 8 +++++--- examples/ssd1680_simpletest.py | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/adafruit_ssd1680.py b/adafruit_ssd1680.py index 490725f..f64d3dc 100755 --- a/adafruit_ssd1680.py +++ b/adafruit_ssd1680.py @@ -18,6 +18,7 @@ * `Adafruit 2.13" Tri-Color eInk Display Breakout `_ * `Adafruit 2.13" Tri-Color eInk Display FeatherWing `_ +* `Adafruit 2.13" Mono eInk Display FeatherWing `_ **Software and Dependencies:** @@ -51,6 +52,7 @@ class SSD1680(displayio.EPaperDisplay): r"""SSD1680 driver :param bus: The data bus the display is on + :param column_correction: Adjust colstart, defaults to 1 (``int``) :param \**kwargs: See below @@ -63,7 +65,7 @@ class SSD1680(displayio.EPaperDisplay): Display rotation """ - def __init__(self, bus: displayio.Fourwire, **kwargs) -> None: + def __init__(self, bus: displayio.Fourwire, column_correction=1, **kwargs) -> None: stop_sequence = bytearray(_STOP_SEQUENCE) try: bus.reset() @@ -95,6 +97,6 @@ def __init__(self, bus: displayio.Fourwire, **kwargs) -> None: set_current_column_command=0x4E, set_current_row_command=0x4F, refresh_display_command=0x20, - colstart=1, + colstart=column_correction, always_toggle_chip_select=True, - ) + ) \ No newline at end of file diff --git a/examples/ssd1680_simpletest.py b/examples/ssd1680_simpletest.py index a8642e7..7a41395 100644 --- a/examples/ssd1680_simpletest.py +++ b/examples/ssd1680_simpletest.py @@ -9,10 +9,9 @@ * https://www.adafruit.com/product/4947 * Adafruit 2.13" Tri-Color eInk Display FeatherWing * https://www.adafruit.com/product/4814 + * Adafruit 2.13" Mono eInk Display FeatherWing + * https://www.adafruit.com/product/4195 -To use Adafruit 2.13" Monochrome FeatherWing - 250x122 Monochrome with SSD1680: - * https://www.adafruit.com/product/4195 - Set change height in display from 122 to 127 """ @@ -35,8 +34,10 @@ ) time.sleep(1) +# For issues with display not updating top/bottom rows correctly set column_correction to 8 display = adafruit_ssd1680.SSD1680( display_bus, + column_correction=1, width=250, height=122, busy_pin=epd_busy, @@ -44,6 +45,7 @@ rotation=270, ) + g = displayio.Group() with open("/display-ruler.bmp", "rb") as f: From ad0ecafa451ab1a8a5f80bfdff538ffbb18309bb Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 20:48:32 +0000 Subject: [PATCH 4/9] corrected formating --- adafruit_ssd1680.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_ssd1680.py b/adafruit_ssd1680.py index f64d3dc..fe48384 100755 --- a/adafruit_ssd1680.py +++ b/adafruit_ssd1680.py @@ -99,4 +99,4 @@ def __init__(self, bus: displayio.Fourwire, column_correction=1, **kwargs) -> No refresh_display_command=0x20, colstart=column_correction, always_toggle_chip_select=True, - ) \ No newline at end of file + ) From 2075bbb03a1dfe1264131506129cc9370a950ac9 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 22:07:17 +0000 Subject: [PATCH 5/9] Update adafruit_ssd1680.py Co-authored-by: Melissa LeBlanc-Williams --- adafruit_ssd1680.py | 1 - 1 file changed, 1 deletion(-) diff --git a/adafruit_ssd1680.py b/adafruit_ssd1680.py index fe48384..1dc6b63 100755 --- a/adafruit_ssd1680.py +++ b/adafruit_ssd1680.py @@ -97,6 +97,5 @@ def __init__(self, bus: displayio.Fourwire, column_correction=1, **kwargs) -> No set_current_column_command=0x4E, set_current_row_command=0x4F, refresh_display_command=0x20, - colstart=column_correction, always_toggle_chip_select=True, ) From f85db076262b2c978952ad83d75a8d411d07769d Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 22:07:25 +0000 Subject: [PATCH 6/9] Update adafruit_ssd1680.py Co-authored-by: Melissa LeBlanc-Williams --- adafruit_ssd1680.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/adafruit_ssd1680.py b/adafruit_ssd1680.py index 1dc6b63..aa99cfc 100755 --- a/adafruit_ssd1680.py +++ b/adafruit_ssd1680.py @@ -65,7 +65,9 @@ class SSD1680(displayio.EPaperDisplay): Display rotation """ - def __init__(self, bus: displayio.Fourwire, column_correction=1, **kwargs) -> None: + def __init__(self, bus: displayio.Fourwire, **kwargs) -> None: + if "colstart" not in kwargs: + kwargs["colstart"] = 1 stop_sequence = bytearray(_STOP_SEQUENCE) try: bus.reset() From 8ec927791b6486094a61d9076c3f04a5d0ef4e04 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 22:07:33 +0000 Subject: [PATCH 7/9] Update adafruit_ssd1680.py Co-authored-by: Melissa LeBlanc-Williams --- adafruit_ssd1680.py | 1 - 1 file changed, 1 deletion(-) diff --git a/adafruit_ssd1680.py b/adafruit_ssd1680.py index aa99cfc..3a0428d 100755 --- a/adafruit_ssd1680.py +++ b/adafruit_ssd1680.py @@ -52,7 +52,6 @@ class SSD1680(displayio.EPaperDisplay): r"""SSD1680 driver :param bus: The data bus the display is on - :param column_correction: Adjust colstart, defaults to 1 (``int``) :param \**kwargs: See below From 3fc67fff323872b70b91585e5f0084510cb630b9 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 22:07:42 +0000 Subject: [PATCH 8/9] Update examples/ssd1680_simpletest.py Co-authored-by: Melissa LeBlanc-Williams --- examples/ssd1680_simpletest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ssd1680_simpletest.py b/examples/ssd1680_simpletest.py index 7a41395..d9ba9d6 100644 --- a/examples/ssd1680_simpletest.py +++ b/examples/ssd1680_simpletest.py @@ -37,7 +37,7 @@ # For issues with display not updating top/bottom rows correctly set column_correction to 8 display = adafruit_ssd1680.SSD1680( display_bus, - column_correction=1, + colstart=1, width=250, height=122, busy_pin=epd_busy, From 9151c72b88209785445c3c26cb3a88b564df4788 Mon Sep 17 00:00:00 2001 From: David Edwards Date: Wed, 15 Feb 2023 22:20:51 +0000 Subject: [PATCH 9/9] Update ssd1680_simpletest.py Corrected guidance comment --- examples/ssd1680_simpletest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ssd1680_simpletest.py b/examples/ssd1680_simpletest.py index d9ba9d6..9ce4f1f 100644 --- a/examples/ssd1680_simpletest.py +++ b/examples/ssd1680_simpletest.py @@ -34,7 +34,7 @@ ) time.sleep(1) -# For issues with display not updating top/bottom rows correctly set column_correction to 8 +# For issues with display not updating top/bottom rows correctly set colstart to 8 display = adafruit_ssd1680.SSD1680( display_bus, colstart=1,