Skip to content

__init__() arguments are not Pin objects #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FoamyGuy opened this issue Jan 24, 2022 · 2 comments
Closed

__init__() arguments are not Pin objects #7

FoamyGuy opened this issue Jan 24, 2022 · 2 comments

Comments

@FoamyGuy
Copy link
Contributor

We recently changed argument names for initializing the ESP32SPI library to use the suffix _dio rather than _pin because the arguments need to be instantiated DigitalInOut objects, not microcontroller.Pin objects.

See: adafruit/Adafruit_CircuitPython_ESP32SPI#121

This library uses the same *_pin names for it's arguments which are also expected to the DigitalInOuts rather than Pins.

I think we'll want to change the names here and any other libraries that have _pin to keep things consistent across libraries.

@jposada202020
Copy link
Contributor

Are we referring here to the example code. If that is the case I could make a PR for that. Thanks :)

@makermelissa
Copy link
Collaborator

makermelissa commented Oct 2, 2023

I've been diving into the eInk code over the past few days and in the case of this library, pins should be used and not DigitalInOut object. Feel free to reopen if there's something you're seeing that I'm not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants