Skip to content

Remove 8px colstart offset #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chimok opened this issue Nov 11, 2024 · 1 comment
Closed

Remove 8px colstart offset #27

chimok opened this issue Nov 11, 2024 · 1 comment

Comments

@chimok
Copy link

chimok commented Nov 11, 2024

Hello,

I have a WeAct 2.9 Epaper Display, it works well with this driver.

But on the top of the screen there was always some random b/w noise visible. I read omewhere the hint to set colstart=8 to fix some issues. But it didn't change anything.

I want to understand if Partial Update is possible with this driver, so i read the source code and found this here:
https://github.com/adafruit/Adafruit_CircuitPython_SSD1680/blob/main/adafruit_ssd1680.py#L76

Without colstart, there is colstart=8 set. This magic causing the issues with my display!
I set colstart=0 and everything was fine.

So I'm wondering isn't it better to remove this default and only add this to docs?

Edit: Found now the PR, still believe its wrong to set a value that works for the majority of displays: #5

@tannewt
Copy link
Member

tannewt commented Nov 25, 2024

It is expected that you'll need to tweak colstart, rowstart, height and width for a given display because it depends on how the display is connected to the SSD1680. The SSD1680 can be connected to the actual display in a variety of ways. I think it is fine to have a default that doesn't work for everything.

Instead of removing the default, I'd suggest you add an example for this particular display. Examples are the best place to start since they can capture specific display settings.

@tannewt tannewt closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants