Skip to content

Commit 65ef2fd

Browse files
authored
Merge pull request #30 from tekktrik/main
Fix pylint issues
2 parents 678d6e3 + 0645e81 commit 65ef2fd

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

adafruit_si5351.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def configure_integer(self, multiplier: int) -> None:
180180
accurate (but more limited) PLL frequency generation.
181181
"""
182182
if multiplier >= 91 or multiplier <= 14:
183-
raise Exception("Multiplier must be in range 14 to 91.")
183+
raise ValueError("Multiplier must be in range 14 to 91.")
184184
multiplier = int(multiplier)
185185
# Compute register values and configure them.
186186
p1 = 128 * multiplier - 512
@@ -203,13 +203,13 @@ def configure_fractional(
203203
susceptible to jitter but allows a larger range of PLL frequencies.
204204
"""
205205
if multiplier >= 91 or multiplier <= 14:
206-
raise Exception("Multiplier must be in range 14 to 91.")
206+
raise ValueError("Multiplier must be in range 14 to 91.")
207207
if denominator > 0xFFFFF or denominator <= 0: # Prevent divide by zero.
208-
raise Exception(
208+
raise ValueError(
209209
"Denominator must be greater than 0 and less than 0xFFFFF."
210210
)
211211
if numerator >= 0xFFFFF or numerator < 0:
212-
raise Exception("Numerator must be in range 0 to 0xFFFFF.")
212+
raise ValueError("Numerator must be in range 0 to 0xFFFFF.")
213213
multiplier = int(multiplier)
214214
numerator = int(numerator)
215215
denominator = int(denominator)
@@ -301,7 +301,7 @@ def r_divider(self) -> int:
301301
@r_divider.setter
302302
def r_divider(self, divider: int) -> None:
303303
if divider > 7 or divider < 0:
304-
raise Exception("Divider must in range 0 to 7.")
304+
raise ValueError("Divider must in range 0 to 7.")
305305
reg_value = self._si5351._read_u8(self._r)
306306
reg_value &= 0x0F
307307
divider &= 0x07
@@ -331,11 +331,11 @@ def configure_integer(
331331
frequency but supports less of a range of values.
332332
"""
333333
if divider >= 2049 or divider <= 3:
334-
raise Exception("Divider must be in range 3 to 2049.")
334+
raise ValueError("Divider must be in range 3 to 2049.")
335335
divider = int(divider)
336336
# Make sure the PLL is configured (has a frequency set).
337337
if pll.frequency is None:
338-
raise Exception("PLL must be configured.")
338+
raise RuntimeError("PLL must be configured.")
339339
# Compute MSx register values.
340340
p1 = 128 * divider - 512
341341
p2 = 0
@@ -370,19 +370,19 @@ def configure_fractional(
370370
"""
371371
# pylint: disable=too-many-arguments
372372
if divider >= 2049 or divider <= 3:
373-
raise Exception("Divider must be in range 3 to 2049.")
373+
raise ValueError("Divider must be in range 3 to 2049.")
374374
if denominator > 0xFFFFF or denominator <= 0: # Prevent divide by zero.
375-
raise Exception(
375+
raise ValueError(
376376
"Denominator must be greater than 0 and less than 0xFFFFF."
377377
)
378378
if numerator >= 0xFFFFF or numerator < 0:
379-
raise Exception("Numerator must be in range 0 to 0xFFFFF.")
379+
raise ValueError("Numerator must be in range 0 to 0xFFFFF.")
380380
divider = int(divider)
381381
numerator = int(numerator)
382382
denominator = int(denominator)
383383
# Make sure the PLL is configured (has a frequency set).
384384
if pll.frequency is None:
385-
raise Exception("PLL must be configured.")
385+
raise RuntimeError("PLL must be configured.")
386386
# Compute MSx register values.
387387
p1 = int(128 * divider + math.floor(128 * (numerator / denominator)) - 512)
388388
p2 = int(

0 commit comments

Comments
 (0)