Skip to content

Short station names not updating #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caternuson opened this issue Aug 28, 2019 · 7 comments · Fixed by #20
Closed

Short station names not updating #9

caternuson opened this issue Aug 28, 2019 · 7 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@caternuson
Copy link
Contributor

In example below, just change station to something with less than 8 characters.

import board, digitalio, adafruit_si4713
si_reset = digitalio.DigitalInOut(board.D10)
si4713 = adafruit_si4713.SI4713(board.I2C(), reset=si_reset, timeout_s=0.5)
si4713.tx_frequency_khz = 87500
si4713.tx_power = 115
si4713.configure_rds(0xADAF, station=b'12345678', rds_buffer=b'solid gold yacht rock')
@kattni kattni added the bug Something isn't working label May 4, 2020
@jposada202020
Copy link
Contributor

jposada202020 commented May 29, 2021

Helllo @caternuson I tested this but could not repeat the issue.

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040
>>> import board
>>> import digitalio
>>> import adafruit_si4713
>>> si_reset = digitalio.DigitalInOut(board.D5)
>>> si4713 = adafruit_si4713.SI4713(board.I2C(), reset=si_reset, timeout_s=0.5)
>>> si4713.tx_frequency_khz = 87500
>>> si4713.tx_power = 115
>>> si4713.configure_rds(0xADAF, station=b'ocho', rds_buffer=b'solid gold yacht rock')
>>>

@caternuson
Copy link
Contributor Author

@jposada202020 What are you using for receiving the RDS info?

@jposada202020
Copy link
Contributor

@caternuson mmmm, Not using not a receiver. Was trying to see where the issue was. So the only thing that I did was change the station.
If I need to do something let me know I would like to work in this issue 😃

@caternuson
Copy link
Contributor Author

I'm trying to remember some of these details myself 😃
I think the issue was on the receiving end. The code would run without errors, but you wouldn't see the updated name on the receiving radio. I'm pretty sure I was using a Zune (yes, a Zune) to test things on the receiving end.

@jposada202020
Copy link
Contributor

Oh dear.... Gotcha.. lets see what I can do :)

@jposada202020
Copy link
Contributor

@caternuson
Ok.. :) .. now the real issue is, when using less than five characters, the station will add bs to the name
image

I will try to troubleshoot this during the weekend now that I have how to test.

according to initial testing I am guessing that the buffer is not being cleared, but I have not even study a single line of code of the library.. :)

@caternuson
Copy link
Contributor Author

@jposada202020 cool. it looks like you generally are recreating the issue. i also did not dig into this very far. seemed like a weird edge case and at the time needed to move on to other things. so just created this issue as a reminder, or for anyone else that might wander into it :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants