-
Notifications
You must be signed in to change notification settings - Fork 35
Version 1.7.x breaks use with MatrixPortal projects because it can't read JSON #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok, I looked into this. The issue is we are grabbing request.text and then request.json() and this causes the error. I'll update the MatrixPortal library to not do this. |
This issue likely affects Adafruit_CircuitPython_PyPortal and possibly Adafruit_Blinka_PyPortal as well. |
I did this to avoid holding onto the full string memory between the text call and the json call. |
That's fine. It was a clear enough message that I figured it out pretty quickly. I would have probably released it as 2.0.0 though. :) |
@makermelissa Ya, fair. I was trying my best to be backwards compatible and maybe I was too optimistic. :-) |
No problem. I have updated the Portal libraries and am unaware of any others this change affects, so closing. |
Uh oh!
There was an error while loading. Please reload this page.
When trying out the OpenWeather Demo (https://learn.adafruit.com/weather-display-matrix/code-the-weather-display-matrix), it works as expected with version 1.6.0 and breaks when updating to 1.7.x.
The lines I noticed related to the error that keep repeating:
The text was updated successfully, but these errors were encountered: