Skip to content

Move typing annotation definitions to circuitpython_typing #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tekktrik opened this issue Aug 6, 2022 · 3 comments
Closed

Move typing annotation definitions to circuitpython_typing #113

tekktrik opened this issue Aug 6, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation Hacktoberfest DigitalOcean's Hacktoberfest

Comments

@tekktrik
Copy link
Member

tekktrik commented Aug 6, 2022

This library may improve from having some of the type annotations reworked and checked, as well as moved to circuitpython_typing. This might improve readability of the library.

@tekktrik tekktrik added documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 6, 2022
@dhalbert
Copy link
Contributor

dhalbert commented Aug 6, 2022

I have a branch where I started to do this: main...dhalbert:Adafruit_CircuitPython_Requests:change-exceptions

@adafruit-adabot adafruit-adabot added the Hacktoberfest DigitalOcean's Hacktoberfest label Sep 29, 2022
@FoamyGuy FoamyGuy removed the good first issue Good for newcomers label Jul 31, 2023
@justmobilize
Copy link
Collaborator

@dhalbert can this be closed? The typing is in adafruit_typing and I removed it from here, and then connection_manager once I saw it in the typing lib

@dhalbert
Copy link
Contributor

Fixed by adafruit/Adafruit_CircuitPython_Typing#35, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Hacktoberfest DigitalOcean's Hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants