Why is the alarm year & month hardcoded to Jan 2017?

[maholli]

When reading an alarm set point, the tm_year attribute is hardcoded to return 2017 and tm_mon to return 1. Is this intentional? Caused by a limitation somewhere?

Adafruit_CircuitPython_Register/adafruit_register/i2c_bcd_alarm.py

Line 154 in d373491

time.struct_time((2017, 1, mday, hour, minute, seconds, wday, mday, -1)),

In contrast, reading the datetime properly returns the year reported from the RTC:

Adafruit_CircuitPython_Register/adafruit_register/i2c_bcd_datetime.py

Line 88 in d373491

_bcd2bin(self.buffer[7] & self.mask_datetime[7]) + 2000,

[tannewt]

I don't remember. It was probably just a known point in time to base the frequency on. Maybe look in the DS3231 (iirc) datasheet for clues.

[maholli]

@tannewt yeah the DS3231 alarm registers specify the time up to the day (date). Not sure how you want this helper library to handle it, but at the very least the docs should include a warning.

[tannewt]

PR to update the doc would be great!