Skip to content

Commit 2ed8676

Browse files
committed
Remove from and to from i2c device reads and writes. The device class handles the address.
1 parent 9c980a4 commit 2ed8676

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,13 @@ we must implement ``__get__`` and ``__set__``.
120120
def __get__(self, obj, objtype=None):
121121
with obj.i2c_device:
122122
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
123-
obj.i2c_device.readfrom_into(self.buffer, start=1)
123+
obj.i2c_device.read_into(self.buffer, start=1)
124124
return bool(self.buffer[1] & self.bit_mask)
125125
126126
def __set__(self, obj, value):
127127
with obj.i2c_device:
128128
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
129-
obj.i2c_device.readfrom_into(self.buffer, start=1)
129+
obj.i2c_device.read_into(self.buffer, start=1)
130130
if value:
131131
self.buffer[1] |= self.bit_mask
132132
else:

adafruit_register/i2c_bcd_alarm.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ def __init__(self, register_address, has_seconds=True, weekday_shared=True, week
8484
def __get__(self, obj, objtype=None):
8585
# Read the alarm register.
8686
with obj.i2c_device:
87-
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
88-
obj.i2c_device.readfrom_into(self.buffer, start=1)
87+
obj.i2c_device.write(self.buffer, end=1, stop=False)
88+
obj.i2c_device.read_into(self.buffer, start=1)
8989

9090
frequency = None
9191
i = 1
@@ -162,4 +162,4 @@ def __set__(self, obj, value):
162162
self.buffer[i + 2] = _bin2bcd(value[0].tm_mday)
163163

164164
with obj.i2c_device:
165-
obj.i2c_device.writeto(self.buffer)
165+
obj.i2c_device.write(self.buffer)

adafruit_register/i2c_bcd_datetime.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ def __init__(self, register_address, weekday_first=True, weekday_start=1):
6565
def __get__(self, obj, objtype=None):
6666
# Read and return the date and time.
6767
with obj.i2c_device:
68-
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
69-
obj.i2c_device.readfrom_into(self.buffer, start=1)
68+
obj.i2c_device.write(self.buffer, end=1, stop=False)
69+
obj.i2c_device.read_into(self.buffer, start=1)
7070
return time.struct_time((_bcd2bin(self.buffer[7]) + 2000,
7171
_bcd2bin(self.buffer[6]),
7272
_bcd2bin(self.buffer[5 - self.weekday_offset]),
@@ -86,4 +86,4 @@ def __set__(self, obj, value):
8686
self.buffer[6] = _bin2bcd(value.month)
8787
self.buffer[7] = _bin2bcd(value.year - 2000)
8888
with obj.i2c_device:
89-
obj.i2c_device.writeto(self.buffer)
89+
obj.i2c_device.write(self.buffer)

adafruit_register/i2c_bit.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,19 @@ def __init__(self, register_address, bit):
3636

3737
def __get__(self, obj, objtype=None):
3838
with obj.i2c_device as i2c:
39-
i2c.writeto(self.buffer, end=1, stop=False)
40-
i2c.readfrom_into(self.buffer, start=1)
39+
i2c.write(self.buffer, end=1, stop=False)
40+
i2c.read_into(self.buffer, start=1)
4141
return bool(self.buffer[1] & self.bit_mask)
4242

4343
def __set__(self, obj, value):
4444
with obj.i2c_device as i2c:
45-
i2c.writeto(self.buffer, end=1, stop=False)
46-
i2c.readfrom_into(self.buffer, start=1)
45+
i2c.write(self.buffer, end=1, stop=False)
46+
i2c.read_into(self.buffer, start=1)
4747
if value:
4848
self.buffer[1] |= self.bit_mask
4949
else:
5050
self.buffer[1] &= ~self.bit_mask
51-
i2c.writeto(self.buffer)
51+
i2c.write(self.buffer)
5252

5353
class ROBit(RWBit):
5454
"""Single bit register that is read only. Subclass of `RWBit`.

adafruit_register/i2c_bits.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,22 +44,22 @@ def __init__(self, num_bits, register_address, lowest_bit):
4444

4545
def __get__(self, obj, objtype=None):
4646
with obj.i2c_device as i2c:
47-
i2c.writeto(self.buffer, end=1, stop=False)
48-
i2c.readfrom_into(self.buffer, start=1)
47+
i2c.write(self.buffer, end=1, stop=False)
48+
i2c.read_into(self.buffer, start=1)
4949
return (self.buffer[1] & self.bit_mask) >> lowest_bit
5050

5151
def __set__(self, obj, value):
5252
# Shift the value to the appropriate spot and set all bits that aren't
5353
# ours to 1 (the negation of the bitmask.)
5454
value = (value << self.lowest_bit) | ~self.bit_mask
5555
with obj.i2c_device as i2c:
56-
i2c.writeto(self.buffer, end=1, stop=False)
57-
i2c.readfrom_into(self.buffer, start=1)
56+
i2c.write(self.buffer, end=1, stop=False)
57+
i2c.read_into(self.buffer, start=1)
5858
# Set all of our bits to 1.
5959
self.buffer[1] |= self.bit_mask
6060
# Set all 0 bits to 0 by anding together.
6161
self.buffer[1] &= value
62-
i2c.writeto(self.buffer)
62+
i2c.write(self.buffer)
6363

6464
class ROBits(RWBits):
6565
"""

adafruit_register/i2c_struct.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ def __init__(self, register_address, struct_format):
3939

4040
def __get__(self, obj, objtype=None):
4141
with obj.i2c_device:
42-
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
43-
obj.i2c_device.readfrom_into(self.buffer, start=1)
42+
obj.i2c_device.write(self.buffer, end=1, stop=False)
43+
obj.i2c_device.read_into(self.buffer, start=1)
4444
return ustruct.unpack_from(self.format, memoryview(self.buffer)[1:])
4545

4646
def __set__(self, obj, value):
4747
ustruct.pack_into(self.format, self.buffer, 1, *value)
4848
with obj.i2c_device:
49-
obj.i2c_device.writeto(self.buffer)
49+
obj.i2c_device.write(self.buffer)
5050

5151
class UnaryStruct:
5252
"""
@@ -65,11 +65,11 @@ def __init__(self, register_address, struct_format):
6565

6666
def __get__(self, obj, objtype=None):
6767
with obj.i2c_device:
68-
obj.i2c_device.writeto(self.buffer, end=1, stop=False)
69-
obj.i2c_device.readfrom_into(self.buffer, start=1)
68+
obj.i2c_device.write(self.buffer, end=1, stop=False)
69+
obj.i2c_device.read_into(self.buffer, start=1)
7070
return ustruct.unpack_from(self.format, memoryview(self.buffer)[1:])[0]
7171

7272
def __set__(self, obj, value):
7373
ustruct.pack_into(self.format, self.buffer, 1, value)
7474
with obj.i2c_device:
75-
obj.i2c_device.writeto(self.buffer)
75+
obj.i2c_device.write(self.buffer)

0 commit comments

Comments
 (0)