From 0c425c9c9be096e1cb821036654f3f5ae0f141f8 Mon Sep 17 00:00:00 2001 From: dherrada Date: Mon, 8 Nov 2021 13:15:17 -0500 Subject: [PATCH] Linted --- .pre-commit-config.yaml | 2 +- examples/rsa_tests.py | 4 ++-- util/decode_priv_key.py | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1b9fadc..43d1385 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -24,7 +24,7 @@ repos: name: pylint (library code) types: [python] args: - - --disable=consider-using-f-string + - --disable=consider-using-f-string,duplicate-code exclude: "^(docs/|examples/|tests/|setup.py$)" - id: pylint name: pylint (example code) diff --git a/examples/rsa_tests.py b/examples/rsa_tests.py index c789caf..177b7e9 100755 --- a/examples/rsa_tests.py +++ b/examples/rsa_tests.py @@ -24,8 +24,8 @@ def test_mod_msg(): msg_enc = adafruit_rsa.encrypt(msg, pub) msg_enc = msg_enc[:-1] + b"X" # change the last byte try: - adafruit_rsa.decrypt(msg_enc, priv) - raise "ERROR: Decrypted message matches original" + msg_dec = adafruit_rsa.decrypt(msg_enc, priv) + assert msg_dec != msg, "ERROR: Decrypted message matches original" except adafruit_rsa.pkcs1.DecryptionError: pass diff --git a/util/decode_priv_key.py b/util/decode_priv_key.py index c756ba2..c673c42 100644 --- a/util/decode_priv_key.py +++ b/util/decode_priv_key.py @@ -21,12 +21,12 @@ import rsa # Generate private and public RSA keys -proc = subprocess.Popen(["openssl", "genrsa", "-out", "rsa_private.pem", "2048"]) -proc.wait() -proc = subprocess.Popen( +with subprocess.Popen(["openssl", "genrsa", "-out", "rsa_private.pem", "2048"]) as proc: + proc.wait() +with subprocess.Popen( ["openssl", "rsa", "-in", "rsa_private.pem", "-pubout", "-out", "rsa_public.pem"] -) -proc.wait() +) as proc: + proc.wait() # Open generated private key file try: