Skip to content

Optional Type hint fails #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eichblatt opened this issue Apr 27, 2023 · 3 comments · Fixed by #113
Closed

Optional Type hint fails #112

eichblatt opened this issue Apr 27, 2023 · 3 comments · Fixed by #113

Comments

@eichblatt
Copy link

This line fails when I try importing this library.

rst: Optional[digitalio] = None,

@FoamyGuy
Copy link
Contributor

@eichblatt can you post the full error?

If possible can you also try the previous release (found here: https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display/releases/tag/3.11.0 ) The library was just recently updated, it's possible we need another tweak on top to get that portion fixed.

@tekktrik
Copy link
Member

My guess is it's failing because Optional is being given a module as an input instead of the DigitalInOut class, I can submit a fix and see if that fixes it.

@eichblatt
Copy link
Author

Sorry for the terse post. By the time I identified the problem, I had already reverted to the old version that I knew worked. So I could not reproduce the error, or find it in my log. But I wanted to make sure that you knew, and figured a terse message was better than no message.

I will unpin the version, and update again. If it breaks, I will collect the error messages and post here.

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants