Skip to content

Should we add fix for SF=6? #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jerryneedell opened this issue Feb 17, 2025 · 1 comment
Open

Should we add fix for SF=6? #95

jerryneedell opened this issue Feb 17, 2025 · 1 comment

Comments

@jerryneedell
Copy link
Contributor

jerryneedell commented Feb 17, 2025

There is a PR in Adadruit_CircuitPython_RFM that fixes a known issue with Spreading Factor = 6

adafruit/Adafruit_CircuitPython_RFM#10

Should this also be implemented here?
It will increase the size of the library and further impact the smaller M0 build (feather M0 rfm9x)?

Users who need SF=6 can use the Adafruit_CircuitPython_RFM library but that will not run on the small M0 boards.

SF=6 is not supported by the RadioHead Arduino library so without it, the adafruit_rfm9x library is still "compatible" with Radiohead ;-)

I don't know how much it will increase the library - likely a few 10s of bytes.

How you would like to proceed?

@tannewt
Copy link
Member

tannewt commented Feb 18, 2025

Let's not fix it now due to code size increase and it not being needed for RadioHead compatibility. Instead, let's leave this issue open in case anyone comes along needing this. Once they do, we can decide if and how to fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants