-
Notifications
You must be signed in to change notification settings - Fork 55
Remove backward-compatible imports when 4.0.0 released #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
On a related note, we have been discussing in discord the usefulness of this in https://github.com/adafruit/Adafruit_CircuitPython_PyPortal/blob/master/adafruit_pyportal.py#L58
The current behaviour for that is to print the warning which cannot be seen as it's only on screen for about 1/4 of a second before the raster display blanks it. The import then has polluted the the code in some way where it blows up later on with a (I had missed the step in instructions to delete the old files on CIRCUITPY in https://learn.adafruit.com/adabox011/updating-your-pyportal and based on forum discussion a small number of other users must have done the same: https://forums.adafruit.com/viewtopic.php?f=59&t=149573) |
we're going to remove it soon when 4 is released which solves it, right? |
Yes, if you are referring to removing the |
Remove the
try
-import
code that supports older versions ofdisplayio
et al when 4.0.0 is released as stable.The text was updated successfully, but these errors were encountered: