Fixup some Pylint issues

Author: hugodahl

adafruit_progressbar/__init__.py

@@ -32,7 +32,7 @@ class ProgressBarBase(displayio.TileGrid):
     :type position: Tuple[int, int]
     :param size: The size (width, height) of the progress bar
     :type size: Tuple[int, int]
-    :param  start_value: The beginning value of the progress bar. This value
+    :param start_value: The beginning value of the progress bar. This value
                               is displayed when the progress bar is first visible,
                               if it hasn't been updated.
     :type start_value: float
@@ -139,6 +139,7 @@ def progress(self):
 
     @property
     def border_thickness(self):
+        """Gets the currently configured thickness of the border (in pixels)"""
         return self._border_thickness
 
     @progress.setter
@@ -149,10 +150,10 @@ def progress(self, value):
                             bar. Must be between 0.0-1.0
         """
         _old_value = self._progress
-        # If we're using floats, from 0.0 to 1.0, using 4 decimal places allows us to handle values as
-        # precise as 0.23456, which evaluates to a percentage value of 23.45% (with rounding)
+        # If we're using floats, from 0.0 to 1.0, using 4 decimal places allows us to handle values
+        # as precise as 0.23456, which evaluates to a percentage value of 23.45% (with rounding)
         self._progress = round(value, 4)
-        self.render(_old_value, self.progress)
+        self.render(_old_value, self.progress, self.progress)
 
     @property
     def range(self):
@@ -184,16 +185,21 @@ def _draw_outline(self):
                 self._bitmap[line, _h] = 1
                 self._bitmap[self.width - 1 - line, _h] = 1
 
-    def render(self, _old_value, _new_value):
+    def render(self, _old_value, _new_value, _progress_value) -> None:
         """The method called when the display needs to be updated. This method
         can be overridden in child classes to handle the graphics appropriately.
 
-        :param _old_value: float: The value from which we're updating
-        :param _new_value: float: The value to which we're updating
-
+        :param _old_value: The value from which we're updating
+        :type _old_value: float
+        :param _new_value: The value to which we're updating
+        :type _new_value: float
+        :param _progress_value: The value of the progress, or ratio between the new value and the
+            maximum value
+        :type _progress_value: float
+        :rtype None:
         """
 
-    def info():
+    def info(self):
         """This is the `info` method. It gives you info.
 
         This information is usefull for debugging, and

adafruit_progressbar/progressbar.py

@@ -70,15 +70,18 @@ def __init__(
             (width, height),
             progress,
             bar_color,
-            0xAAAAAA,
+            outline_color,
             0x444444,
             border_thickness=stroke,
             show_margin=True,
             value_range=(0.0, 1.0),
         )
 
+    _outline_color: int  # The colour used for the border of the widget
+
     @property
     def progress(self):
+        """Returns the current progress value (percentage)"""
         return ProgressBarBase.progress.fget(self)
 
     @progress.setter
@@ -93,8 +96,15 @@ def progress(self, value):
             value, float
         ), "Progress value must be a floating point value."
 
+        # pylint: disable=no-member
         ProgressBarBase.progress.fset(self, value)
 
+    @property
+    def outline_color(self):
+        """Returns the currently configured value for the color of the
+        outline (border) of the widget."""
+        return self._outline_color
+
     @property
     def fill(self):
         """The fill of the progress bar. Can be a hex value for a color or ``None`` for
@@ -114,7 +124,7 @@ def fill(self, color):
             self._palette[2] = color
             self._palette.make_opaque(0)
 
-    def render(self, _previous_value, _new_value, _progress_value):
+    def render(self, _previous_value, _new_value, _progress_value) -> None:
         """
         The rendering mechanism to display the newly set value.
 
@@ -125,7 +135,7 @@ def render(self, _previous_value, _new_value, _progress_value):
         :param _progress_value: The value of the progress, or ratio between the new value and the
             maximum value
         :type _progress_value: float
-        :return: None
+        :rtype None:
         """
         #         print("Calling 'super().render()' before our own code")
         #         super().render()

adafruit_progressbar/verticalprogressbar.py

@@ -24,11 +24,15 @@
 """
 
 # imports
-from . import ProgressBarBase
 import displayio
+from . import ProgressBarBase
+
 
+# pylint: disable=too-few-public-methods
+class FillDirection(enumerate):
+    """Enums to define the direction in which the progressbar
+    should fill"""
 
-class FillDirection(object):
     LEFT_TO_RIGHT = 0
     DEFAULT = LEFT_TO_RIGHT
     BOTTOM_UP = 1
@@ -209,7 +213,7 @@ def progress(self, value):
 
         # DEBUG
         print(
-            f"Start: {_start}   End: {_end}    Incr: {_incr}   Size: {_new_value_size}    Color: {_color}"
+            f"Start: {_start}  End: {_end}  Incr: {_incr}  Size: {_new_value_size}  Color: {_color}"
         )
 
         # Because range() is ( from-include, to-exclude )...