Merge pull request #4 from FoamyGuy/main

pylint to precommit

Author: kattni

.github/workflows/build.yml

@@ -50,10 +50,6 @@ jobs:
     - name: Pre-commit hooks
       run: |
         pre-commit run --all-files
-    - name: PyLint
-      run: |
-        pylint $( find . -path './adafruit*.py' )
-        ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/*.py" ))
     - name: Build assets
       run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location .
     - name: Build docs

.pre-commit-config.yaml

@@ -4,11 +4,11 @@
 
 repos:
 -   repo: https://github.com/python/black
-    rev: 19.10b0
+    rev: 20.8b1
     hooks:
     - id: black
 -   repo: https://github.com/fsfe/reuse-tool
-    rev: 20.8b1
+    rev: v0.12.1
     hooks:
     - id: reuse
 -   repo: https://github.com/pre-commit/pre-commit-hooks
@@ -17,4 +17,19 @@ repos:
     -   id: check-yaml
     -   id: end-of-file-fixer
     -   id: trailing-whitespace
+-   repo: https://github.com/pycqa/pylint
+    rev: pylint-2.7.1
+    hooks:
+    -   id: pylint
+        name: pylint (library code)
+        types: [python]
+        exclude: "^(docs/|examples/|setup.py$)"
+-   repo: local
+    hooks:
+    -   id: pylint_examples
+        name: pylint (examples code)
+        description: Run pylint rules on "examples/*.py" files
+        entry: /usr/bin/env bash -c
+        args: ['([[ ! -d "examples" ]] || for example in $(find . -path "./examples/*.py"); do pylint --disable=missing-docstring,invalid-name $example; done)']
+        language: system
 exclude: \.png$

.pylintrc

@@ -250,7 +250,7 @@ ignore-comments=yes
 ignore-docstrings=yes
 
 # Ignore imports when computing similarities.
-ignore-imports=no
+ignore-imports=yes
 
 # Minimum lines number of a similarity.
 min-similarity-lines=4

examples/pixel_framebuf_16x16_animation.py

@@ -9,10 +9,18 @@
 pixel_height = 16
 
 pixels = neopixel.NeoPixel(
-    pixel_pin, pixel_width * pixel_height, brightness=0.1, auto_write=False,
+    pixel_pin,
+    pixel_width * pixel_height,
+    brightness=0.1,
+    auto_write=False,
 )
 
-pixel_framebuf = PixelFramebuffer(pixels, pixel_width, pixel_height, reverse_x=True,)
+pixel_framebuf = PixelFramebuffer(
+    pixels,
+    pixel_width,
+    pixel_height,
+    reverse_x=True,
+)
 
 text = "Welcome to CircuitPython"
 

examples/pixel_framebuf_32x8_test.py

@@ -9,7 +9,10 @@
 pixel_height = 8
 
 pixels = neopixel.NeoPixel(
-    pixel_pin, pixel_width * pixel_height, brightness=0.1, auto_write=False,
+    pixel_pin,
+    pixel_width * pixel_height,
+    brightness=0.1,
+    auto_write=False,
 )
 
 pixel_framebuf = PixelFramebuffer(

examples/pixel_framebuf_dotstar_simpletest.py

@@ -12,10 +12,19 @@
 pixel_height = 6
 
 pixels = adafruit_dotstar.DotStar(
-    board.D13, board.D11, pixel_width * pixel_height, brightness=0.3, auto_write=False,
+    board.D13,
+    board.D11,
+    pixel_width * pixel_height,
+    brightness=0.3,
+    auto_write=False,
 )
 
-pixel_framebuf = PixelFramebuffer(pixels, pixel_width, pixel_height, alternating=False,)
+pixel_framebuf = PixelFramebuffer(
+    pixels,
+    pixel_width,
+    pixel_height,
+    alternating=False,
+)
 
 pixel_framebuf.fill(0x000088)
 pixel_framebuf.pixel(5, 1, 0xFFFF00)

examples/pixel_framebuf_pillow_image.py

@@ -19,10 +19,18 @@
 pixel_height = 16
 
 pixels = neopixel.NeoPixel(
-    pixel_pin, pixel_width * pixel_height, brightness=0.1, auto_write=False,
+    pixel_pin,
+    pixel_width * pixel_height,
+    brightness=0.1,
+    auto_write=False,
 )
 
-pixel_framebuf = PixelFramebuffer(pixels, pixel_width, pixel_height, reverse_x=True,)
+pixel_framebuf = PixelFramebuffer(
+    pixels,
+    pixel_width,
+    pixel_height,
+    reverse_x=True,
+)
 
 # Make a black background in RGBA Mode
 image = Image.new("RGBA", (pixel_width, pixel_height))

examples/pixel_framebuf_simpletest.py

@@ -12,10 +12,18 @@
 pixel_height = 4
 
 pixels = neopixel.NeoPixel(
-    pixel_pin, pixel_width * pixel_height, brightness=0.1, auto_write=False,
+    pixel_pin,
+    pixel_width * pixel_height,
+    brightness=0.1,
+    auto_write=False,
 )
 
-pixel_framebuf = PixelFramebuffer(pixels, pixel_width, pixel_height, alternating=False,)
+pixel_framebuf = PixelFramebuffer(
+    pixels,
+    pixel_width,
+    pixel_height,
+    alternating=False,
+)
 
 pixel_framebuf.fill(0x000088)
 pixel_framebuf.pixel(5, 1, 0xFFFF00)