@@ -173,11 +173,12 @@ def load_game(self, game_directory):
173
173
)
174
174
self ._gamefilename = game_directory + "/cyoa.json"
175
175
try :
176
- game_file = open (self ._gamefilename , "r" )
176
+ with open ( # pylint: disable=unspecified-encoding
177
+ self ._gamefilename , "r"
178
+ ) as game_file :
179
+ self ._game = json .load (game_file )
177
180
except OSError as err :
178
181
raise OSError ("Could not open game file " + self ._gamefilename ) from err
179
- self ._game = json .load (game_file )
180
- game_file .close ()
181
182
182
183
def _fade_to_black (self ):
183
184
"""Turn down the lights."""
@@ -343,7 +344,7 @@ def play_sound(self, filename, *, wait_to_finish=True, loop=False):
343
344
except AttributeError :
344
345
self ._display .wait_for_frame ()
345
346
try :
346
- self ._wavfile = open (filename , "rb" )
347
+ self ._wavfile = open (filename , "rb" ) # pylint: disable=consider-using-with
347
348
except OSError as err :
348
349
raise OSError ("Could not locate sound file" , filename ) from err
349
350
@@ -403,8 +404,10 @@ def set_background(self, filename, *, with_fade=True):
403
404
if filename :
404
405
if self ._background_file :
405
406
self ._background_file .close ()
406
- self ._background_file = open (self ._gamedirectory + "/" + filename , "rb" )
407
- background = displayio .OnDiskBitmap (self ._background_file )
407
+ with open (
408
+ self ._gamedirectory + "/" + filename , "rb"
409
+ ) as self ._background_file :
410
+ background = displayio .OnDiskBitmap (self ._background_file )
408
411
self ._background_sprite = displayio .TileGrid (
409
412
background ,
410
413
pixel_shader = getattr (
0 commit comments