-
Notifications
You must be signed in to change notification settings - Fork 3
Add Missing Type Annotations #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like there's a few things I found not caused by any of your commits but related to this update, so I've mentioned them too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a couple more things I noticed.
Thanks! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.18 from 1.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#20 from jposada202020/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.19 from 2.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#36 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.14 from 1.0.13: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#8 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.6 from 2.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#110 from tlyu/comet-doc Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
resolves #4
submitted for review / comment