[doc] Example of servo sweep is wrong #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jvalrog opened this issue Jan 24, 2021 · 2 comments

Contributor

jvalrog commented Jan 24, 2021

The code for that example is wrong. It lacks delays so the sweep is useless.

The example file is this: https://github.com/adafruit/Adafruit_CircuitPython_PCA9685/blob/master/examples/pca9685_servo.py

And it differs from this other one from the Motor library (it's actually the same example but this one has delays): https://github.com/adafruit/Adafruit_CircuitPython_Motor/blob/master/examples/motor_pca9685_servo_sweep.py

Member

ladyada commented Jan 24, 2021

hi please submit a PR for a version with delays then

Contributor

jposada202020 commented May 25, 2021

Closed by #36

jposada202020 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment