Skip to content

Commit 33460da

Browse files
authored
Merge pull request #39 from relic-se/contrast-getter
Fix contrast property read
2 parents 36e1684 + eeaebc6 commit 33460da

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

adafruit_ov5640/__init__.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,11 +1510,15 @@ def brightness(self, value: int) -> None:
15101510
@property
15111511
def contrast(self) -> int:
15121512
"""Sensor contrast adjustment, from -3 to 3 inclusive"""
1513-
contrast_abs = self._read_register(0x5587) >> 4
1514-
contrast_neg = self._read_register(0x5588) & 8
1515-
if contrast_neg:
1516-
return -contrast_abs
1517-
return contrast_abs
1513+
try:
1514+
value = _contrast_settings.index(
1515+
[self._read_register(0x5586), self._read_register(0x5585)]
1516+
)
1517+
except ValueError:
1518+
value = 0
1519+
if value > 3:
1520+
value -= len(_contrast_settings)
1521+
return value
15181522

15191523
@contrast.setter
15201524
def contrast(self, value: int) -> None:

0 commit comments

Comments
 (0)