Skip to content

The tz_offset attribute is a float, not an int. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BiffoBear opened this issue Jun 21, 2023 · 2 comments
Closed

The tz_offset attribute is a float, not an int. #29

BiffoBear opened this issue Jun 21, 2023 · 2 comments

Comments

@BiffoBear
Copy link

tz_offset: int = 0 should be tz_offset: float = 0.0 as India is at UTC +5.5 hours for example.

self._tz_offset = tz_offset * 60 * 60 can be cast to int if required.
@joshua-beck-0908
Copy link
Contributor

Yeah, having the exact same problem in Australia. There's lots of sloppy timezone code out there that assumes all time zones are aligned to whole-hour intervals. I'll see if I can put in a pull request.

@Neradoc Neradoc mentioned this issue Jul 3, 2023
Merged
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Jul 7, 2023

resolved by #30

@FoamyGuy FoamyGuy closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FoamyGuy @BiffoBear @joshua-beck-0908