Skip to content

Remove methods on DCMotor and ContinuousServo #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalbert opened this issue Nov 8, 2018 · 3 comments
Closed

Remove methods on DCMotor and ContinuousServo #18

dhalbert opened this issue Nov 8, 2018 · 3 comments

Comments

@dhalbert
Copy link
Contributor

dhalbert commented Nov 8, 2018

DCMotor and ContinuousServo, but not regular Servo, provide a deinit() operation that sets .throttle to 0. However, they don't actually deinit anything: you could change the speed again in the future.

I'm not sure why they were added (they were in from the start). I think we could just delete them.

Came up while @caternuson was recoding an Arduino example (see #17), but this is a separate issue.

Tagging @tannewt for any comment.

@tannewt
Copy link
Member

tannewt commented Nov 12, 2018

I'm ok if you want to remove it. They are there to match how you use other CircuitPython classes. Either way is fine.

@geekguy-wy
Copy link

I will remove them. PR #37 fixes this

@FoamyGuy
Copy link
Contributor

This PR was merged, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants