Skip to content

Error when decoding _status_last when the reset() function fails #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisbailey4 opened this issue Jan 17, 2021 · 2 comments
Closed

Comments

@chrisbailey4
Copy link
Contributor

I ran into a particularly weird case where my chip was in a bad state. In my attempt to debug, I noticed that the status being set by the line:

self._status_last = self._transceive(bytes([_CMD_RT]))

aka self._status_last = self._transceive(bytes([_CMD_RT])). was slightly wrong and if I attempted to call the display_status I would get a type error.

I made a local change to address this:

data = self._transceive(bytes([_CMD_RT]))
self._status_last = data[0]

I am happy to make a PR to address this minor corner case and support the library if you would like.

@ladyada
Copy link
Member

ladyada commented Jan 17, 2021

yep please submit a PR!

@caternuson
Copy link
Contributor

Closing. Should be fixed by #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants