Skip to content

simpletest example not handling in_channel tuples #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caternuson opened this issue Mar 6, 2021 · 0 comments · Fixed by #32
Closed

simpletest example not handling in_channel tuples #30

caternuson opened this issue Mar 6, 2021 · 0 comments · Fixed by #32

Comments

@caternuson
Copy link

Re this thread:
https://forums.adafruit.com/viewtopic.php?f=60&t=176352#p859127

in_channel can be a tuple, which the example code does not handle:

Adafruit_CircuitPython_MIDI/examples/midi_simpletest.py

Lines 20 to 23 in 41b021b

print(
"Listening on input channel:",
midi.in_channel + 1 if midi.in_channel is not None else None,
)

@jepler jepler linked a pull request Mar 18, 2021 that will close this issue
update midi_simpletest.py from Limor #32
Merged
@jepler jepler closed this as completed in #32 Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update midi_simpletest.py from Limor jepler/Adafruit_CircuitPython_MIDI
1 participant
@caternuson