Skip to content

Use "address" not "device_address" for specifying the I2C address, for consistency with other drivers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deshipu opened this issue Apr 4, 2018 · 4 comments
Closed

Use "address" not "device_address" for specifying the I2C address, for consistency with other drivers #12

deshipu opened this issue Apr 4, 2018 · 4 comments

Comments

@deshipu
Copy link
Contributor

deshipu commented Apr 4, 2018

We need a consistent API between different drivers, and all I2C-based drivers should use the same keywords.
@tannewt
Copy link
Member

tannewt commented Apr 4, 2018

I'd rather move to device_address so it doesn't get confused with memory address.

@deshipu
Copy link
Contributor Author

deshipu commented Apr 4, 2018

Well, that would involve changing a lot of code out there. And I think the context is pretty clear here.

@tannewt
Copy link
Member

tannewt commented Apr 5, 2018

Ok, address is fine.

@kattni
Copy link
Contributor

kattni commented Jul 24, 2018

This was fixed by #13 . Closing.

@kattni kattni closed this as completed Jul 24, 2018
sommersoft referenced this issue in sommersoft/Adafruit_CircuitPython_MCP9808 Dec 19, 2018
@deshipu
fix#12: use "address" not "device_address" keyword
b946fdf 
To be consistent with other drivers.
sommersoft referenced this issue in sommersoft/Adafruit_CircuitPython_MCP9808 Dec 19, 2018
@tannewt
Merge pull request adafruit#13 from adafruit/deshipu-patch-1
870a559 
fix#12: use "address" not "device_address" keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tannewt @deshipu @kattni