From 384f117db673d2ff3144c262468a4dbf8e31bbed Mon Sep 17 00:00:00 2001 From: dherrada Date: Sun, 15 Mar 2020 15:00:49 -0400 Subject: [PATCH] Ran black, updated to pylint 2.x --- .github/workflows/build.yml | 2 +- adafruit_max9744.py | 22 ++++--- docs/conf.py | 110 +++++++++++++++++++-------------- examples/max9744_simpletest.py | 6 +- setup.py | 50 +++++++-------- 5 files changed, 102 insertions(+), 88 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fff3aa9..1dad804 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,7 +40,7 @@ jobs: source actions-ci/install.sh - name: Pip install pylint, black, & Sphinx run: | - pip install --force-reinstall pylint==1.9.2 black==19.10b0 Sphinx sphinx-rtd-theme + pip install --force-reinstall pylint black==19.10b0 Sphinx sphinx-rtd-theme - name: Library version run: git describe --dirty --always --tags - name: PyLint diff --git a/adafruit_max9744.py b/adafruit_max9744.py index d79239f..f7e0c80 100644 --- a/adafruit_max9744.py +++ b/adafruit_max9744.py @@ -47,15 +47,15 @@ __repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_MAX9744.git" -#pylint: disable=bad-whitespace +# pylint: disable=bad-whitespace # Internal constants: -_MAX9744_DEFAULT_ADDRESS = const(0b01001011) -_MAX9744_COMMAND_VOLUME = const(0b00000000) -_MAX9744_COMMAND_FILTERLESS = const(0b01000000) +_MAX9744_DEFAULT_ADDRESS = const(0b01001011) +_MAX9744_COMMAND_VOLUME = const(0b00000000) +_MAX9744_COMMAND_FILTERLESS = const(0b01000000) _MAX9744_COMMAND_CLASSIC_PWM = const(0b01000001) -_MAX9744_COMMAND_VOLUME_UP = const(0b11000100) +_MAX9744_COMMAND_VOLUME_UP = const(0b11000100) _MAX9744_COMMAND_VOLUME_DOWN = const(0b11000101) -#pylint: enable=bad-whitespace +# pylint: enable=bad-whitespace class MAX9744: @@ -97,9 +97,13 @@ def _set_volume(self, volume): assert 0 <= volume <= 63 self._write(_MAX9744_COMMAND_VOLUME | (volume & 0x3F)) - #pylint: disable=line-too-long - volume = property(None, _set_volume, "Set the volume of the amplifier. Specify a value from 0-63 where 0 is muted/off and 63 is maximum volume.") - #pylint: enable=line-too-long + # pylint: disable=line-too-long + volume = property( + None, + _set_volume, + "Set the volume of the amplifier. Specify a value from 0-63 where 0 is muted/off and 63 is maximum volume.", + ) + # pylint: enable=line-too-long def volume_up(self): """Increase the volume by one level.""" diff --git a/docs/conf.py b/docs/conf.py index bc36c90..ff445e8 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -2,7 +2,8 @@ import os import sys -sys.path.insert(0, os.path.abspath('..')) + +sys.path.insert(0, os.path.abspath("..")) # -- General configuration ------------------------------------------------ @@ -10,9 +11,9 @@ # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom # ones. extensions = [ - 'sphinx.ext.autodoc', - 'sphinx.ext.intersphinx', - 'sphinx.ext.viewcode', + "sphinx.ext.autodoc", + "sphinx.ext.intersphinx", + "sphinx.ext.viewcode", ] # Uncomment the below if you use native CircuitPython modules such as @@ -20,29 +21,32 @@ # autodoc module docs will fail to generate with a warning. # autodoc_mock_imports = ["micropython"] -intersphinx_mapping = {'python': ('https://docs.python.org/3.4', None),'CircuitPython': ('https://circuitpython.readthedocs.io/en/latest/', None)} +intersphinx_mapping = { + "python": ("https://docs.python.org/3.4", None), + "CircuitPython": ("https://circuitpython.readthedocs.io/en/latest/", None), +} # Add any paths that contain templates here, relative to this directory. -templates_path = ['_templates'] +templates_path = ["_templates"] -source_suffix = '.rst' +source_suffix = ".rst" # The master toctree document. -master_doc = 'index' +master_doc = "index" # General information about the project. -project = u'Adafruit MAX9744 Library' -copyright = u'2017 Tony DiCola' -author = u'Tony DiCola' +project = u"Adafruit MAX9744 Library" +copyright = u"2017 Tony DiCola" +author = u"Tony DiCola" # The version info for the project you're documenting, acts as replacement for # |version| and |release|, also used in various other places throughout the # built documents. # # The short X.Y version. -version = u'1.0' +version = u"1.0" # The full version, including alpha/beta/rc tags. -release = u'1.0' +release = u"1.0" # The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages. @@ -54,7 +58,7 @@ # List of patterns, relative to source directory, that match files and # directories to ignore when looking for source files. # This patterns also effect to html_static_path and html_extra_path -exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store', '.env', 'CODE_OF_CONDUCT.md'] +exclude_patterns = ["_build", "Thumbs.db", ".DS_Store", ".env", "CODE_OF_CONDUCT.md"] # The reST default role (used for this markup: `text`) to use for all # documents. @@ -66,7 +70,7 @@ add_function_parentheses = True # The name of the Pygments (syntax highlighting) style to use. -pygments_style = 'sphinx' +pygments_style = "sphinx" # If true, `todo` and `todoList` produce output, else they produce nothing. todo_include_todos = False @@ -80,59 +84,62 @@ # The theme to use for HTML and HTML Help pages. See the documentation for # a list of builtin themes. # -on_rtd = os.environ.get('READTHEDOCS', None) == 'True' +on_rtd = os.environ.get("READTHEDOCS", None) == "True" if not on_rtd: # only import and set the theme if we're building docs locally try: import sphinx_rtd_theme - html_theme = 'sphinx_rtd_theme' - html_theme_path = [sphinx_rtd_theme.get_html_theme_path(), '.'] + + html_theme = "sphinx_rtd_theme" + html_theme_path = [sphinx_rtd_theme.get_html_theme_path(), "."] except: - html_theme = 'default' - html_theme_path = ['.'] + html_theme = "default" + html_theme_path = ["."] else: - html_theme_path = ['.'] + html_theme_path = ["."] # Add any paths that contain custom static files (such as style sheets) here, # relative to this directory. They are copied after the builtin static files, # so a file named "default.css" will overwrite the builtin "default.css". -html_static_path = ['_static'] +html_static_path = ["_static"] # The name of an image file (relative to this directory) to use as a favicon of # the docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32 # pixels large. # -html_favicon = '_static/favicon.ico' +html_favicon = "_static/favicon.ico" # Output file base name for HTML help builder. -htmlhelp_basename = 'AdafruitMax9744Librarydoc' +htmlhelp_basename = "AdafruitMax9744Librarydoc" # -- Options for LaTeX output --------------------------------------------- latex_elements = { - # The paper size ('letterpaper' or 'a4paper'). - # - # 'papersize': 'letterpaper', - - # The font size ('10pt', '11pt' or '12pt'). - # - # 'pointsize': '10pt', - - # Additional stuff for the LaTeX preamble. - # - # 'preamble': '', - - # Latex figure (float) alignment - # - # 'figure_align': 'htbp', + # The paper size ('letterpaper' or 'a4paper'). + # + # 'papersize': 'letterpaper', + # The font size ('10pt', '11pt' or '12pt'). + # + # 'pointsize': '10pt', + # Additional stuff for the LaTeX preamble. + # + # 'preamble': '', + # Latex figure (float) alignment + # + # 'figure_align': 'htbp', } # Grouping the document tree into LaTeX files. List of tuples # (source start file, target name, title, # author, documentclass [howto, manual, or own class]). latex_documents = [ - (master_doc, 'AdafruitMAX9744Library.tex', u'AdafruitMAX9744 Library Documentation', - author, 'manual'), + ( + master_doc, + "AdafruitMAX9744Library.tex", + u"AdafruitMAX9744 Library Documentation", + author, + "manual", + ), ] # -- Options for manual page output --------------------------------------- @@ -140,8 +147,13 @@ # One entry per manual page. List of tuples # (source start file, name, description, authors, manual section). man_pages = [ - (master_doc, 'AdafruitMAX9744library', u'Adafruit MAX9744 Library Documentation', - [author], 1) + ( + master_doc, + "AdafruitMAX9744library", + u"Adafruit MAX9744 Library Documentation", + [author], + 1, + ) ] # -- Options for Texinfo output ------------------------------------------- @@ -150,7 +162,13 @@ # (source start file, target name, title, author, # dir menu entry, description, category) texinfo_documents = [ - (master_doc, 'AdafruitMAX9744Library', u'Adafruit MAX9744 Library Documentation', - author, 'AdafruitMAX9744Library', 'One line description of project.', - 'Miscellaneous'), + ( + master_doc, + "AdafruitMAX9744Library", + u"Adafruit MAX9744 Library Documentation", + author, + "AdafruitMAX9744Library", + "One line description of project.", + "Miscellaneous", + ), ] diff --git a/examples/max9744_simpletest.py b/examples/max9744_simpletest.py index 457e887..bbaa0a5 100644 --- a/examples/max9744_simpletest.py +++ b/examples/max9744_simpletest.py @@ -14,17 +14,17 @@ amp = adafruit_max9744.MAX9744(i2c) # Optionally you can specify a different addres if you override the AD1, AD2 # pins to change the address. -#amp = adafruit_max9744.MAX9744(i2c, address=0x49) +# amp = adafruit_max9744.MAX9744(i2c, address=0x49) # Setting the volume is as easy as writing to the volume property (note # you cannot read the property so keep track of volume in your own code if # you need it). amp.volume = 31 # Volume is a value from 0 to 63 where 0 is muted/off and - # 63 is maximum volume. +# 63 is maximum volume. # In addition you can call a function to instruct the amp to move up or down # a single volume level. This is handy if you just have up/down buttons in # your project for volume: -amp.volume_up() # Increase volume by one level. +amp.volume_up() # Increase volume by one level. amp.volume_down() # Decrease volume by one level. diff --git a/setup.py b/setup.py index 6b3211a..c854569 100644 --- a/setup.py +++ b/setup.py @@ -7,6 +7,7 @@ # Always prefer setuptools over distutils from setuptools import setup, find_packages + # To use a consistent encoding from codecs import open from os import path @@ -14,47 +15,38 @@ here = path.abspath(path.dirname(__file__)) # Get the long description from the README file -with open(path.join(here, 'README.rst'), encoding='utf-8') as f: +with open(path.join(here, "README.rst"), encoding="utf-8") as f: long_description = f.read() setup( - name='adafruit-circuitpython-max9744', - + name="adafruit-circuitpython-max9744", use_scm_version=True, - setup_requires=['setuptools_scm'], - - description='CircuitPython library for MAX9744 20W class D amplifier.', + setup_requires=["setuptools_scm"], + description="CircuitPython library for MAX9744 20W class D amplifier.", long_description=long_description, - long_description_content_type='text/x-rst', - + long_description_content_type="text/x-rst", # The project's main homepage. - url='https://github.com/adafruit/Adafruit_CircuitPython_MAX9744', - + url="https://github.com/adafruit/Adafruit_CircuitPython_MAX9744", # Author details - author='Adafruit Industries', - author_email='circuitpython@adafruit.com', - - install_requires=['Adafruit-Blinka'], - + author="Adafruit Industries", + author_email="circuitpython@adafruit.com", + install_requires=["Adafruit-Blinka"], # Choose your license - license='MIT', - + license="MIT", # See https://pypi.python.org/pypi?%3Aaction=list_classifiers classifiers=[ - 'Development Status :: 3 - Alpha', - 'Intended Audience :: Developers', - 'Topic :: Software Development :: Libraries', - 'Topic :: System :: Hardware', - 'License :: OSI Approved :: MIT License', - 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', - 'Programming Language :: Python :: 3.5', + "Development Status :: 3 - Alpha", + "Intended Audience :: Developers", + "Topic :: Software Development :: Libraries", + "Topic :: System :: Hardware", + "License :: OSI Approved :: MIT License", + "Programming Language :: Python :: 3", + "Programming Language :: Python :: 3.4", + "Programming Language :: Python :: 3.5", ], - # What does your project relate to? - keywords='adafruit amplifier max9744 breakout hardware micropython circuitpython', - + keywords="adafruit amplifier max9744 breakout hardware micropython circuitpython", # You can just specify the packages manually here if your project is # simple. Or you can use find_packages(). - py_modules=['adafruit_max9744'], + py_modules=["adafruit_max9744"], )