type_annotations #20
Merged
type_annotations #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
tekktrik
requested changes
Jan 27, 2023
|
Included suggestions. Thanks for reviewing. :) |
tekktrik
requested changes
Jan 28, 2023
Co-authored-by: Alec Delaney <[email protected]>
|
No worries :) thanks for reviewing my quality control is called brute-force patiently ;) so I appreciate the feedback. ill push another commit as the CI failed. Thanks |
|
Sorry for the delay a little bit of GIT fun :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 28, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.18 from 1.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#20 from jposada202020/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.19 from 2.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#36 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.14 from 1.0.13: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#8 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.6 from 2.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#110 from tlyu/comet-doc Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Type Annotations for this library.
I have tried to use
However when I tried to build the documentation locally it raises an error. so I used I2CDevice and bytearray instead.
Thanks :)