Skip to content
This repository was archived by the owner on Oct 29, 2019. It is now read-only.

Library functions aren't consistent with design guide #2

Closed
caternuson opened this issue Mar 1, 2018 · 4 comments
Closed

Library functions aren't consistent with design guide #2

caternuson opened this issue Mar 1, 2018 · 4 comments
Assignees

Comments

@caternuson
Copy link
Contributor

Ref: http://circuitpython.readthedocs.io/en/latest/docs/design_guide.html#sensor-properties-and-units

Currently have accelerometer and magnetometer. These should be acceleration and magnetic. Suggest keeping current ones and adding in the new ones.

Also, accelerometer is returning a list, not a tuple.

@ladyada
Copy link
Member

ladyada commented Mar 1, 2018

ooh good catch - i'm ok with a breaking change since this is a very new driver
@kattni wanna take this one? :)

@kattni
Copy link
Contributor

kattni commented Mar 1, 2018

Sure thing!

@ladyada to clarify: you'd rather simply alter what's there and remove the incorrect naming?

@ladyada
Copy link
Member

ladyada commented Mar 1, 2018

yes that is correct - thank u kattni :)

@caternuson
Copy link
Contributor Author

Closing. Fixed by #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants