-
Notifications
You must be signed in to change notification settings - Fork 23
Split the core driver from the board specific subclasses #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have done the split into separate files. |
My PR #32 was going in that direction and was ready since a long time. Adafruit should show the way and make a library that only deal with that chip, and then have separated library for individual piece of hardware, including those made by Adafruit. There are a lot of other hardware from Pimoroni (and maybe other) that use that chip:
If there is a pattern that need to be followed, then Adafruit should show the way and contributor will mimic that for their addition, but each contributor that only care about a board he want to add should not hold the burden of refactoring everything. I did the refactoring work to split the library into module once, but I cannot cope with this twice. |
@dglaude no problem - if you close the PR, we'll redo the refactor |
@ladyada I just want to point out a missed opportunities and that there is not point for me to work on my free time and have that wasted. There was an issue, I provided a PR for it and nothing was done with it. Right now someone just need to add the work of Sandy (but he has pending PR to fix what was already accepted). So whatever I do, there is the risk of having a PR spoil it, and I am not a GIT ninja. Look at what is coming or potentially coming, just today there are two new usage from this library, both linked to Pico:
It is up to you to decide if and how you would like to embrace the potential contribution from those author, but it is obvious that a refactoring of the code need to be fast and not stay as a PR for month or this kind of things will keep happening and the library size keep increasing (not a problem for Pico, but a problem for some M0 board). |
To be discussed "In the Weed". |
@dglaude there's no fault - there was nobody formally assigned to merge it and update all the documentation so nobody checked up on it. if you don't want to rebase, which is what it sounds like, close the PR and we'll redo the refactor. |
@dglaude, after looking over this, I'm going to grab the code from your PR and manually merge #35 into it as well as some other outstanding PRs. So in other words, I'll submit a new PR to supersedes it as well as others, but it will incorporate the initial work you did. #32 should have probably been merged first, but we can only go forward from here. |
Fixed via #38. |
The board specific wrappers should live in separate files from the core class so that other boards' code isn't loaded into memory. They could even live in separate product level libraries (aka repos) instead of this one which should be IC level.
The text was updated successfully, but these errors were encountered: