Skip to content

Init argument names should not use Pin #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FoamyGuy opened this issue Jan 24, 2022 · 3 comments
Closed

Init argument names should not use Pin #14

FoamyGuy opened this issue Jan 24, 2022 · 3 comments

Comments

@FoamyGuy
Copy link
Contributor

We recently changed argument names for initializing the ESP32SPI library to use the suffix _dio rather than _pin because the arguments need to be instantiated DigitalInOut objects, not microcontroller.Pin objects.

See: adafruit/Adafruit_CircuitPython_ESP32SPI#121

This library uses the same *_pin names for it's arguments which are also expected to the DigitalInOuts rather than Pins.

I think we'll want to change the names here and any other libraries that have _pin to keep things consistent across libraries.

@tekktrik
Copy link
Member

tekktrik commented Feb 2, 2022

Is this correct? I don't see reference to *_pin arguments, or do they come from displayio.EPaperDisplay?

@tekktrik
Copy link
Member

@FoamyGuy I think this should be closed since it doesn't seem to be an issue with this library. There aren't any pin/IO arguments to the main class in this library, and even the base EPaperDisplay seems to only have one _pin argument which does take a Pin object according to the docs.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Apr 1, 2024

Yep, I don't see any DigitalInOut's either, closing this

@FoamyGuy FoamyGuy closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants