Skip to content

This code does not match device datasheet #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peterhinch opened this issue Jan 13, 2021 · 3 comments
Closed

This code does not match device datasheet #16

peterhinch opened this issue Jan 13, 2021 · 3 comments

Comments

@peterhinch
Copy link
Contributor

These lines show a 2-bit number shifted left 5 to set RES1 and RES0 resolution selection bits. The datasheet shows these as being D7 and D6, consequently the left shift should be 6.
@tannewt
Copy link
Member

tannewt commented Jan 13, 2021

Nice find! Mind making a PR?

@peterhinch peterhinch mentioned this issue Jan 14, 2021
Merged
@peterhinch
Copy link
Contributor Author

Now done #18

@tannewt
Copy link
Member

tannewt commented Jan 14, 2021

Fixed by #18. Thank you!

@tannewt tannewt closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tannewt @peterhinch