-
Notifications
You must be signed in to change notification settings - Fork 28
Port changes to the number() routine in the micropython library to _number() #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
makermelissa
merged 9 commits into
adafruit:master
from
hybotix:port_number_change_from_micropython
Jan 27, 2020
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
05f7c24
Port the change to the _number() function I made to the micropython
84506be
Found and fixed several bugs in the _number() routine. Did much more
c2615fc
Fixed bad whitespace to make PyLint happy.
3345cf7
Deleted some whitespace and parens to make PyLint happy
7a56c85
Fixed a variable name change I missed when changing s to stnum.
56945d5
Moved docstring into the function, removed parens from if checks. Rev…
73165d4
Fixed indent on docstring.
3f2d74c
Removed trailing whitespace in docstring.
11fe810
Removed commented out line.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nitpick, can we remove this commented out line please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I would have nitpicked that too.