Skip to content

Auto write causing flicker in some cases. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caternuson opened this issue Jan 28, 2019 · 4 comments
Closed

Auto write causing flicker in some cases. #29

caternuson opened this issue Jan 28, 2019 · 4 comments
Assignees

Comments

@caternuson
Copy link
Contributor

See here:
https://forums.adafruit.com/viewtopic.php?f=60&t=146815

Auto write is probably calling show() too often. Need to trace through and scrub code and make sure it only gets called as needed.

@caternuson caternuson self-assigned this Jan 28, 2019
@makermelissa
Copy link
Collaborator

I noticed one trouble spot is that it gets called in the fill() function, which is called in the middle of _number(). Perhaps save the current state of auto_fill, set it to false, do all the function calls for _number() call show() and then restore it to the saved state.

@caternuson
Copy link
Contributor Author

Good points. The auto-write was added later, so it was kind of shoe horned in. It's a bit of a mess and I only self assigned this issue since it's my mess. But if you want to PR something, please do.

@makermelissa
Copy link
Collaborator

Sounds good, I'll go ahead and do that. I got really familiar with it when writing the latest addition to Adafruit_CircuitPython_FeatherWing.

@caternuson
Copy link
Contributor Author

Fixed with #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants