Skip to content

_parse_gpgsa and _parse_gpgsv are unused. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesamouraipourpre opened this issue Feb 10, 2021 · 0 comments · Fixed by #54
Closed

_parse_gpgsa and _parse_gpgsv are unused. #51

lesamouraipourpre opened this issue Feb 10, 2021 · 0 comments · Fixed by #54

Comments

@lesamouraipourpre
Copy link
Contributor

The methods _parse_gpgsa() and _parse_gpgsv() are never called from the message parser update(). The also leads to the following variables never being updated sel_mode, fix_quality_3d, sat_prns, pdop, hdop, vdop & satellites_prev.

The GSA (GPS DOP and active satellites) and GSV (Satellites in view) messages looks like they might provide useful extra information if received.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement GSV and GSA parsing
1 participant
@lesamouraipourpre