Skip to content

Typo in NMEA sentence checking #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
digixx opened this issue May 7, 2020 · 3 comments
Closed

Typo in NMEA sentence checking #44

digixx opened this issue May 7, 2020 · 3 comments

Comments

@digixx
Copy link

digixx commented May 7, 2020

Hi,

in adafruit_gps.py, line 142
if data_type in ( b"GPGLL", b"GNGGL", ):

GNGGL should be GNGLL?

Kind regards from Switzerland
@evaherrada
Copy link
Collaborator

@digixx Yep, looks like you're right. Feel free to put in a PR fixing this, or, if youd prefer, I can.

@digixx
Copy link
Author

digixx commented May 7, 2020

@dherrada if you can do it, that would be fine.

@evaherrada evaherrada mentioned this issue May 7, 2020
Merged
@evaherrada
Copy link
Collaborator

Fixed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digixx @evaherrada