Skip to content

Commit 35f4904

Browse files
committed
replace partition with split
partition is not available on all boards
1 parent f89329a commit 35f4904

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

adafruit_gps.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,11 @@ def _read_deg_mins(data: List[str], index: int, neg: str) -> Tuple[int, float]:
130130
# longitudes, which makes parsing tricky:
131131
# for latitudes: ddmm,mmmm (0 - 7 decimal places, not zero padded)
132132
# for longitudes: dddmm,mmmm (0 - 7 decimal places, not zero padded)
133-
int_part, _, minutes_decimal = data[index].partition(".")
133+
if "." in data[index]:
134+
int_part, minutes_decimal = data[index].split(".")
135+
else:
136+
int_part, minutes_decimal = data[index], 0
137+
134138
# we need to parse from right to left, minutes can only have 2 digits
135139
minutes_int = int_part[-2:]
136140
# the rest must be degrees which are either 2 or 3 digits

tests/adafruit_gps_test.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -489,13 +489,13 @@ def test_GPS_update_from_GSV_both_parts_sats_are_removed():
489489
@pytest.mark.parametrize(
490490
("input_str", "exp", "neg"),
491491
(
492-
(["3723.2475", "N"], (37, 23.2475), "S"),
493-
(["3723.2475", "S"], (-37, 23.2475), "s"),
494-
(["00123.1234", "E"], (1, 23.1234), "W"),
495-
(["00123", "E"], (1, 23), "W"),
496-
(["1234.5678", "E"], (12, 34.5678), "W"),
497-
(["3723.2475123", "N"], (37, 23.2475123), "S"),
498-
(["3723", "N"], (37, 23), "S"),
492+
(["3723.2475", "n"], (37, 23.2475), "s"),
493+
(["3723.2475", "s"], (-37, 23.2475), "s"),
494+
(["00123.1234", "e"], (1, 23.1234), "w"),
495+
(["00123", "e"], (1, 23), "w"),
496+
(["1234.5678", "e"], (12, 34.5678), "w"),
497+
(["3723.2475123", "n"], (37, 23.2475123), "s"),
498+
(["3723", "n"], (37, 23), "s"),
499499
),
500500
)
501501
def test_read_min_secs(input_str, exp, neg):

0 commit comments

Comments
 (0)