From a322e31debc9d6997372e9a050e23a9c0cfdcefd Mon Sep 17 00:00:00 2001 From: lucashadfield Date: Sun, 25 Jul 2021 09:14:16 +1000 Subject: [PATCH 1/2] fixing flat top triangle bug --- adafruit_gfx/gfx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_gfx/gfx.py b/adafruit_gfx/gfx.py index 8c251c3..27b3cae 100755 --- a/adafruit_gfx/gfx.py +++ b/adafruit_gfx/gfx.py @@ -276,7 +276,7 @@ def fill_triangle(self, x0, y0, x1, y1, x2, y2, *args, **kwargs): dy12 = 1 sa = 0 sb = 0 - if y1 == y2: + if y1 == y2 or y0 == y1: last = y1 else: last = y1 - 1 From 8a68766a1020dbbaeb7f7879ff10cf757070a526 Mon Sep 17 00:00:00 2001 From: Scott Shawcroft Date: Mon, 26 Jul 2021 14:24:18 -0700 Subject: [PATCH 2/2] Pylint disable. Existing is clear enough --- adafruit_gfx/gfx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_gfx/gfx.py b/adafruit_gfx/gfx.py index 27b3cae..cf7feac 100755 --- a/adafruit_gfx/gfx.py +++ b/adafruit_gfx/gfx.py @@ -276,7 +276,7 @@ def fill_triangle(self, x0, y0, x1, y1, x2, y2, *args, **kwargs): dy12 = 1 sa = 0 sb = 0 - if y1 == y2 or y0 == y1: + if y1 == y2 or y0 == y1: # pylint: disable=consider-using-in last = y1 else: last = y1 - 1