Ran pylint and black

Author: [email protected]

.pylintrc

@@ -208,7 +208,7 @@ redefining-builtins-modules=six.moves,future.builtins
 
 # Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
 # expected-line-ending-format=
-expected-line-ending-format=LF
+expected-line-ending-format=CRLF
 
 # Regexp for a line that is allowed to be longer than the limit.
 ignore-long-lines=^\s*(# )?<?https?://\S+>?$

adafruit_fingerprint.py

@@ -208,7 +208,7 @@ def load_model(self, location, slot=1):
     def get_fpdata(self, sensorbuffer="char", slot=1):
         """Requests the sensor to transfer the fingerprint image or
         template.  Returns the data payload only."""
-        if slot != 1 and slot != 2:
+        if slot not in (1, 2):
             # raise error or use default value?
             slot = 2
         if sensorbuffer == "image":
@@ -219,14 +219,14 @@ def get_fpdata(self, sensorbuffer="char", slot=1):
             raise RuntimeError("Uknown sensor buffer type")
         if self._get_packet(12)[0] == 0:
             res = self._get_data(9)
-            self._print_debug("get_fpdata data size:",  str(len(res)))
+            self._print_debug("get_fpdata data size:", str(len(res)))
         self._print_debug("get_fdata res:", res, data_type="hex")
         return res
 
     def send_fpdata(self, data, sensorbuffer="char", slot=1):
         """Requests the sensor to receive data, either a fingerprint image or
         a character/template data.  Data is the payload only."""
-        if slot != 1 and slot != 2:
+        if slot not in (1, 2):
             # raise error or use default value?
             slot = 2
         if sensorbuffer == "image":
@@ -294,7 +294,6 @@ def finger_fast_search(self):
     def close_uart(self):
         """close serial port"""
         self._uart.close()
-        return
 
     def finger_search(self):
         """Asks the sensor to search for a matching fingerprint starting at
@@ -314,7 +313,7 @@ def compare_templates(self):
         """Compares two fingerprint templates in char buffers 1 and 2. Stores the confidence score
         in self.finger_id and self.confidence. Returns the packet error code or
         OK success"""
-        self._send_packet( [_COMPARE] )
+        self._send_packet([_COMPARE])
         r = self._get_packet(14)
         self.confidence = struct.unpack(">H", bytes(r[1:3]))
         self._print_debug("compare_templates confidence:", self.confidence)
@@ -437,7 +436,7 @@ def _send_packet(self, data):
     def _send_data(self, data):
         self._print_debug("_send_data length:", len(data))
         self._print_debug("_send_data data:", data, data_type="hex")
-        #self.read_sysparam() #moved this to init
+        # self.read_sysparam() #moved this to init
         if self.data_packet_size == 0:
             data_length = 32
         elif self.data_packet_size == 1:
@@ -471,7 +470,7 @@ def _send_data(self, data):
             packet.append(length & 0xFF)
             checksum = _DATAPACKET + (length >> 8) + (length & 0xFF)
 
-            #for j in range(len(data[start:end])):
+            # for j in range(len(data[start:end])):
             for j in range(start, end):
                 packet.append(data[j])
                 checksum += data[j]
@@ -491,12 +490,11 @@ def soft_reset(self):
 
     def _print_debug(self, info, data, data_type="str"):
         """Prints debugging information. This is activated
-           by flag _debug"""
+        by flag _debug"""
         if not self._debug:
             return
 
         if data_type == "hex":
             print("*** DEBUG ==>", info, ["{:02x}".format(i) for i in data])
         elif data_type == "str":
             print("*** DEBUG ==>", info, data)
-

examples/fingerprint_template_file_compare.py

@@ -1,6 +1,27 @@
 # SPDX-FileCopyrightText: 2021 ladyada for Adafruit Industries
 # SPDX-License-Identifier: MIT
 
+"""
+`fingerprint_template_file_compare.py`
+====================================================
+
+This is an example program to demo storing fingerprint templates in a file. It also allows
+comparing a newly obtained print with one stored in the file in previous step. This is helpful
+when fingerprint templates are stored centrally (not on sensor's flash memory) and shared
+between multiple sensors.
+
+* Author(s): admiralmaggie
+
+Implementation Notes
+--------------------
+
+**Hardware:**
+
+* `Fingerprint sensor <https://www.adafruit.com/product/751>`_ (Product ID: 751)
+* `Panel Mount Fingerprint sensor <https://www.adafruit.com/product/4651>`_ (Product ID: 4651)
+"""
+
+
 import serial
 import adafruit_fingerprint
 
@@ -9,7 +30,7 @@
 # uart = busio.UART(board.TX, board.RX, baudrate=57600)
 
 # If using with a computer such as Linux/RaspberryPi, Mac, Windows with USB/serial converter:
-uart = serial.Serial("COM4", baudrate=57600, timeout=1)
+uart = serial.Serial("COM6", baudrate=57600, timeout=1)
 
 # If using with Linux/Raspberry Pi and hardware UART:
 # uart = serial.Serial("/dev/ttyS0", baudrate=57600, timeout=1)
@@ -33,7 +54,7 @@ def sensor_reset():
 # pylint: disable=too-many-branches
 def fingerprint_check_file():
     """Compares a new fingerprint template to an existing template stored in a file
-       This is useful when templates are stored centrally (i.e. in a database)"""
+    This is useful when templates are stored centrally (i.e. in a database)"""
     print("Waiting for finger print...")
     set_led_local(color=3, mode=1)
     while finger.get_image() != adafruit_fingerprint.OK:
@@ -43,8 +64,8 @@ def fingerprint_check_file():
         return False
 
     print("Loading file template...", end="", flush=True)
-    with open('template0.dat', 'rb') as f:
-        data = f.read()
+    with open("template0.dat", "rb") as file:
+        data = file.read()
     finger.send_fpdata(list(data), "char", 2)
 
     i = finger.compare_templates()
@@ -125,20 +146,21 @@ def enroll_save_to_file():
 
     print("Downloading template...")
     data = finger.get_fpdata("char", 1)
-    with open("template0.dat", "wb") as f:
-        f.write(bytearray(data))
+    with open("template0.dat", "wb") as file:
+        file.write(bytearray(data))
     set_led_local(color=2, speed=150, mode=6)
     print("Template is saved in template0.dat file.")
 
     return True
 
+
 def set_led_local(color=1, mode=3, speed=0x80, cycles=0):
     """this is to make sure LED doesn't interfer with example
-       running on models without LED support - needs testing"""
+    running on models without LED support - needs testing"""
     try:
         finger.set_led(color, mode, speed, cycles)
-    except:
-        pass
+    except Exception as exc:
+        print("INFO: Sensor les not support LED!")
 
 
 set_led_local(color=3, mode=2, speed=10, cycles=10)
@@ -164,7 +186,7 @@ def set_led_local(color=1, mode=3, speed=0x80, cycles=0):
     print("----------------")
     c = input("> ")
 
-    if c == "x" or c == "q":
+    if c in ("x", "q"):
         print("Exiting fingerprint example program")
         # turn off LED
         set_led_local(mode=4)
@@ -176,4 +198,4 @@ def set_led_local(color=1, mode=3, speed=0x80, cycles=0):
     elif c == "r":
         sensor_reset()
     else:
-        print("Invalid choice: Try again")
+        print("Invalid choice: Try again")