From fa931c0aee51303b71574a0c234fe6c08c16ec48 Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Mon, 2 May 2022 21:38:37 -0400 Subject: [PATCH 1/3] Swap import order Should prevent an unnecessary import this way! --- adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py b/adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py index 30a6b3b..0053a29 100755 --- a/adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py @@ -17,8 +17,8 @@ import adafruit_espatcontrol.adafruit_espatcontrol_socket as socket try: - from adafruit_espatcontrol.adafruit_espatcontrol import ESP_ATcontrol from typing import Dict, Protocol, Any, Optional, Union, Tuple + from adafruit_espatcontrol.adafruit_espatcontrol import ESP_ATcontrol class Pixel(Protocol): """ From 706f28ba08f063427df04f1310c412a9536ddd2d Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Mon, 2 May 2022 21:39:27 -0400 Subject: [PATCH 2/3] Prevent unnecessary import --- adafruit_espatcontrol/adafruit_espatcontrol_socket.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py index 2a09197..febb2f6 100644 --- a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py @@ -6,8 +6,8 @@ from micropython import const try: - from .adafruit_espatcontrol import ESP_ATcontrol from typing import Optional, Tuple, List + from .adafruit_espatcontrol import ESP_ATcontrol except ImportError: pass From 7c6b995e1a424e81a01727dafbc3c91b4c5bd472 Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Mon, 2 May 2022 21:40:41 -0400 Subject: [PATCH 3/3] Move import after typing import --- adafruit_espatcontrol/adafruit_espatcontrol.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol.py b/adafruit_espatcontrol/adafruit_espatcontrol.py index 05574b3..3b8e005 100644 --- a/adafruit_espatcontrol/adafruit_espatcontrol.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol.py @@ -37,8 +37,8 @@ from digitalio import Direction, DigitalInOut try: - import busio from typing import Optional, Dict, Union, List + import busio except ImportError: pass