Skip to content

Dotstar updates are slow #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhooper opened this issue May 29, 2018 · 6 comments
Closed

Dotstar updates are slow #25

rhooper opened this issue May 29, 2018 · 6 comments

Comments

@rhooper
Copy link
Contributor

rhooper commented May 29, 2018

The dotstar library could benefit from a CircuitPython helper to offload computationally expensive setitem work to.
See adafruit/circuitpython#884

@rhooper
Copy link
Contributor Author

rhooper commented May 29, 2018

I have done some experimental work on this for Neopixels, see adafruit/circuitpython#884 and adafruit/Adafruit_CircuitPython_NeoPixel#27

@kattni
Copy link
Contributor

kattni commented May 4, 2020

@tannewt This needs to be updated to work with pixelbuf as well. There is some work here: https://github.com/rhooper/Adafruit_CircuitPython_DotStar/blob/pixelbuf/adafruit_dotstar.py

@tannewt
Copy link
Member

tannewt commented May 4, 2020

@dunkmann00 want to take a stab at it?

@dunkmann00
Copy link
Contributor

Sure! I don't have any dotstars to test it though. But I think it should be straight forward enough, especially since there is already some work done on it.

@tannewt
Copy link
Member

tannewt commented May 5, 2020

@dunkmann00 That'd be awesome. We can find someone with DotStars to verify the code. Thanks!

@kattni
Copy link
Contributor

kattni commented May 11, 2020

We did it!

@kattni kattni closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants