Skip to content

line not documented properly #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Aug 4, 2020 · 5 comments · Fixed by #22
Closed

line not documented properly #21

kattni opened this issue Aug 4, 2020 · 5 comments · Fixed by #22

Comments

@kattni
Copy link

kattni commented Aug 4, 2020

The line module is not added to the api.rst file, so RTD isn't rendering the documentation within it. This needs to be fixed.

@kmatch98 If you have time, please look into this. Feel free to ping me with questions if you have any.

@kmatch98
Copy link

kmatch98 commented Aug 4, 2020

@kattni. I will take a look at this.

I have no idea what a lot of those letters you wrote mean, but let me poke around a bit and I will strive to come up with a few intelligent questions. :)

Running list:
RTD = ReadTheDocs documentation system

Sphinx = a system for generating documentation for Python code

https://brandons-sphinx-tutorial.readthedocs.io/en/latest/index.html

@kattni
Copy link
Author

kattni commented Aug 4, 2020

@kmatch98 I mistakenly thought you added the line module because your PR was the most recently merged. You're still welcome to look into this, but I should tag the original author as well so they know for future reference. If you're not comfortable sorting this out, we can defer to her to get it fixed up. Let me know what you think.

@makermelissa Tagging you on this issue as you are the one who added theline module. May need you to step in to resolve the issue, but let kmatch98 let us know where they're at.

@kmatch98
Copy link

kmatch98 commented Aug 4, 2020

@kattni No worries. I recently added a different function (Sparkline) so it probably needs the same attention to the documentation. If you’re not in a hurry I will take a look at it and see if I can deal with Line and Sparkline at the same time.

If you need it done promptly then I will leave it to @makermelissa and I will follow her lead.

@kattni
Copy link
Author

kattni commented Aug 4, 2020

@kmatch98 I'm not in a hurry. I'd rather encourage a learning opportunity than rush it. Let me know if/when you have questions!

@makermelissa
Copy link
Collaborator

Thanks @kattni, I probably forgot to add it to the api.rst file. I have a few minutes, so I can go in and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants