Skip to content

Button has a Group, but is not a subclass of Group #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalbert opened this issue Aug 24, 2019 · 3 comments · Fixed by #13
Closed

Button has a Group, but is not a subclass of Group #12

dhalbert opened this issue Aug 24, 2019 · 3 comments · Fixed by #13
Assignees

Comments

@dhalbert
Copy link

dhalbert commented Aug 24, 2019

JMK expected a Button to act like a Label, in that it would be a Group that you would add to a Group. But Button is not a subclass of Group: It has a Group (.group), but it is not itself one.

There is a mirrored page in Learn Guides with an example that assumes a Button is a Group:
https://learn.adafruit.com/pyportal-calculator-using-the-displayio-ui-elements/ui-quickstart#button-3-15
https://learn.adafruit.com/circuitpython-display-support-using-displayio/ui-quickstart

Is it possible for it to be Group? If not, the examples should be fixed, and the documentation here should explain how to use .group.

Tagging @makermelissa @tannewt @ladyada

@ladyada
Copy link
Member

ladyada commented Aug 24, 2019

i vaguely recall there was a reason i had to do it this way, like it wasnt working to make it a group subclass, but im almost sure its been fixed now.
@makermelissa wanna try makin' it a group? it will either Totally Work or you'll bump into the thing i did.

@makermelissa
Copy link
Collaborator

Sure, I can give it a try.

@makermelissa makermelissa self-assigned this Aug 24, 2019
@tannewt
Copy link
Member

tannewt commented Aug 26, 2019

Yup, it used to not work but now it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants