-
Notifications
You must be signed in to change notification settings - Fork 19
Ensure Monday is wday 0 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looking into this, it seems as if the driver code is correct, but the example is wrong. I can confirm this and submit a PR to update the example code. Happy to modify the guide to match if that's possible through Github. |
Datasheet for reference: https://datasheets.maximintegrated.com/en/ds/DS3231.pdf It looks like the time is being set correctly since the weekday number is user-defined and auto-increments. The register library seems to be set up correctly here as well, setting Monday as 0 to the register's 1 for first weekday. |
A PR would be great. Some examples are automatically updated in Learn. If this one isn't, then let me know and I can fix it. Thanks! |
Sounds great! Hardware on the way to dot i's and cross t's, but I can submit the PR to correct the example. :) |
Should be resolved by #39 ! |
Thank you! |
Issue brought up on the forum here: https://forums.adafruit.com/viewtopic.php?f=60&t=182751
The text was updated successfully, but these errors were encountered: