Skip to content

Ensure Monday is wday 0 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tannewt opened this issue Aug 30, 2021 · 6 comments
Closed

Ensure Monday is wday 0 #36

tannewt opened this issue Aug 30, 2021 · 6 comments

Comments

@tannewt
Copy link
Member

tannewt commented Aug 30, 2021

Issue brought up on the forum here: https://forums.adafruit.com/viewtopic.php?f=60&t=182751

@tekktrik
Copy link
Member

Looking into this, it seems as if the driver code is correct, but the example is wrong. I can confirm this and submit a PR to update the example code. Happy to modify the guide to match if that's possible through Github.

@tekktrik
Copy link
Member

Datasheet for reference: https://datasheets.maximintegrated.com/en/ds/DS3231.pdf

It looks like the time is being set correctly since the weekday number is user-defined and auto-increments. The register library seems to be set up correctly here as well, setting Monday as 0 to the register's 1 for first weekday.

@tannewt
Copy link
Member Author

tannewt commented Nov 23, 2021

A PR would be great. Some examples are automatically updated in Learn. If this one isn't, then let me know and I can fix it. Thanks!

@tekktrik
Copy link
Member

Sounds great! Hardware on the way to dot i's and cross t's, but I can submit the PR to correct the example. :)

@tekktrik
Copy link
Member

tekktrik commented Dec 1, 2021

Should be resolved by #39 !

@tannewt
Copy link
Member Author

tannewt commented Dec 2, 2021

Thank you!

@tannewt tannewt closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants