Skip to content

DPS310_Advanced not passing on non-default I2C address #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caternuson opened this issue Mar 29, 2022 · 5 comments
Closed

DPS310_Advanced not passing on non-default I2C address #21

caternuson opened this issue Mar 29, 2022 · 5 comments

Comments

@caternuson
Copy link
Contributor

Re this thread:
https://forums.adafruit.com/viewtopic.php?f=60&t=189700

The DPS310_Advanced subclass needs to pass the address parameter on to super. Instead, it's passing the _DPS310_DEFAULT_ADDRESS const:

Adafruit_CircuitPython_DPS310/adafruit_dps310/advanced.py

Line 200 in 8c4112e

super().__init__(i2c_bus, _DPS310_DEFAULT_ADDRESS)

@ladyada
Copy link
Member

ladyada commented Mar 29, 2022

@caternuson i can put together a patch or you can - either way

@caternuson caternuson mentioned this issue Mar 29, 2022
Merged
@caternuson
Copy link
Contributor Author

@ladyada tis but a wee wittle fix. got it with #22. :)

@tekktrik
Copy link
Member

Is this solved then?

@caternuson
Copy link
Contributor Author

Probably. But let's wait till there's a release so it gets in bundle and can then have the forum poster try it out.

@caternuson
Copy link
Contributor Author

They report success:
https://forums.adafruit.com/viewtopic.php?f=60&t=189700&p=918650#p918590

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ladyada @caternuson @tekktrik