From 1d3929fe561a4e26da83c7fe04565c02790b80bd Mon Sep 17 00:00:00 2001 From: yeyeto2788 Date: Mon, 14 Dec 2020 09:36:21 +0100 Subject: [PATCH 1/3] Fix issue #32 --- adafruit_dht.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_dht.py b/adafruit_dht.py index e7f1a64..bc14bfd 100644 --- a/adafruit_dht.py +++ b/adafruit_dht.py @@ -160,7 +160,7 @@ def _get_pulses_bitbang(self): timestamp = time.monotonic() # take timestamp dhtval = True # start with dht pin true because its pulled up dhtpin.direction = Direction.INPUT - dhtpin.pull = Pull.UP + dhtpin.pull = None while time.monotonic() - timestamp < 0.25: if dhtval != dhtpin.value: dhtval = not dhtval # we toggled From bcf42064e32104b8879cb200372ffe9d55c4ac3b Mon Sep 17 00:00:00 2001 From: yeyeto2788 Date: Mon, 14 Dec 2020 09:42:23 +0100 Subject: [PATCH 2/3] Update adafruit_dht.py Fix issue on linting removing not used variable from digitalio --- adafruit_dht.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_dht.py b/adafruit_dht.py index bc14bfd..6e310e5 100644 --- a/adafruit_dht.py +++ b/adafruit_dht.py @@ -31,7 +31,7 @@ import array import time from os import uname -from digitalio import DigitalInOut, Pull, Direction +from digitalio import DigitalInOut, Direction _USE_PULSEIO = False try: From f61a5103382e96571597661d1b9b4345bdd171f6 Mon Sep 17 00:00:00 2001 From: yeyeto2788 Date: Mon, 14 Dec 2020 19:56:05 +0100 Subject: [PATCH 3/3] Update adafruit_dht.py Catch the exception raised by blinka. --- adafruit_dht.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/adafruit_dht.py b/adafruit_dht.py index 6e310e5..be869b2 100644 --- a/adafruit_dht.py +++ b/adafruit_dht.py @@ -31,7 +31,7 @@ import array import time from os import uname -from digitalio import DigitalInOut, Direction +from digitalio import DigitalInOut, Pull, Direction _USE_PULSEIO = False try: @@ -160,7 +160,15 @@ def _get_pulses_bitbang(self): timestamp = time.monotonic() # take timestamp dhtval = True # start with dht pin true because its pulled up dhtpin.direction = Direction.INPUT - dhtpin.pull = None + + try: + dhtpin.pull = Pull.UP + # Catch the NotImplementedError raised because + # blinka.microcontroller.generic_linux.libgpiod_pin does not support + # internal pull resistors. + except NotImplementedError: + dhtpin.pull = None + while time.monotonic() - timestamp < 0.25: if dhtval != dhtpin.value: dhtval = not dhtval # we toggled