Skip to content

Pylint 2.x doesn't like passing object into class #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evaherrada opened this issue Mar 4, 2020 · 4 comments · Fixed by #17
Closed

Pylint 2.x doesn't like passing object into class #16

evaherrada opened this issue Mar 4, 2020 · 4 comments · Fixed by #17
Assignees

Comments

@evaherrada
Copy link
Collaborator

evaherrada commented Mar 4, 2020

Pylint 2.x says this:

************* Module adafruit_cursorcontrol.cursorcontrol
adafruit_cursorcontrol/cursorcontrol.py:46:0: R0205: Class 'Cursor' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)

The line referenced:

I'm not sure why object is passed in, but I'm interested to find out why it was done.

Referencing main issue: adafruit/Adafruit_CircuitPython_Bundle#232

@evaherrada
Copy link
Collaborator Author

@kattni

@brentru
Copy link
Member

brentru commented Mar 4, 2020

@dherrada I could remove and test this later today if you want to assign me to it?

@evaherrada
Copy link
Collaborator Author

@brentru Ya, that'd be great. Thanks

@tannewt
Copy link
Member

tannewt commented Mar 4, 2020

Note, subclassing from (object) is a Python 2 thing and not needed in 3 (as the lint says). It should work exactly the same without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants