Skip to content

Change in LSM6DS library will break this one. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dglaude opened this issue Aug 20, 2020 · 3 comments
Closed

Change in LSM6DS library will break this one. #32

dglaude opened this issue Aug 20, 2020 · 3 comments

Comments

@dglaude
Copy link

dglaude commented Aug 20, 2020

I believe that the recent restructing of this library https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS will break CLUE library.

It's mostly this line import adafruit_lsm6ds and the few usage of it.

@ladyada
Copy link
Member

ladyada commented Aug 20, 2020

@dglaude could be! can you submit a PR that fixes it?

@dglaude
Copy link
Author

dglaude commented Aug 21, 2020

Sorry, I don't know how to fix it.

Whatever syntax I use for the import and syntax I give on line 241 self._accelerometer = adafruit_lsm6ds.LSM6DS33(self._i2c) it keep saying stuff like AttributeError: 'module' object has no attribute 'LSM6DS33'

I gave an advance warning on Discord and I was told to open an issue.
Despite that LSM6DS 4.1.0 introducing the breaking change was released:
https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS/releases/tag/4.1.0

My idea would have been to release the same day a fix for this library together with the release of LSM6DS to avoid having one bundle that contain incompatible library.

@siddacious siddacious mentioned this issue Aug 21, 2020
@dglaude
Copy link
Author

dglaude commented Aug 22, 2020

That fix works for me.

@dglaude dglaude closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants