Skip to content

Check up on setEnvironmentalData() pull request from Adafruit_CCS811_python #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brennen opened this issue Aug 21, 2018 · 7 comments
Closed
Assignees

Comments

@brennen
Copy link
Contributor

brennen commented Aug 21, 2018

We had a pull request over there from @Blu-Eagle that should probably be evaluated with this version of the code:

adafruit/Adafruit_CCS811_python#2

@ladyada
Copy link
Member

ladyada commented Aug 21, 2018

@deanm1278 we archived the python repo, so take a look if this PR is relevant here!

@kattni
Copy link
Contributor

kattni commented Dec 3, 2018

@ladyada Who should we have look into this? Thanks!

@ladyada
Copy link
Member

ladyada commented Dec 3, 2018

might be a good one for carter to check out - no rush on it :)

@kattni
Copy link
Contributor

kattni commented Dec 3, 2018

@caternuson No rush on this. If you get a chance, please look into it. Thanks!

@caternuson caternuson self-assigned this Dec 3, 2018
@caternuson
Copy link
Contributor

caternuson commented Dec 13, 2018

Issue seems real. Reading datasheet and comparing to code, I came to same conclusion and ended up with a fix that is equivalent to the other PR. Not sure what the original code was trying to do. This is a pretty straight forward register write.

Update submitted in #26

@caternuson
Copy link
Contributor

OK to close? No rush.

...or is there?
2112

@caternuson
Copy link
Contributor

Closing Stage Left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants