Skip to content

add a note about CirPy v6.3.0+ having this lib baked in #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2bndy5 opened this issue Jun 25, 2021 · 2 comments · Fixed by #68
Closed

add a note about CirPy v6.3.0+ having this lib baked in #67

2bndy5 opened this issue Jun 25, 2021 · 2 comments · Fixed by #68

Comments

@2bndy5
Copy link
Contributor

2bndy5 commented Jun 25, 2021

I was wondering if it would be prudent to add a note (probably in the README) about how v6.3.0+ of Circuitpython firmware already has this lib included. I haven't checked thoroughly if this is true for all boards running CirPy (ie ATSAMD21)

After some testing, I found the SPIDevice class (from firmware) executes slightly faster than this pure python implementation. 💯
@tannewt
Copy link
Member

tannewt commented Jun 28, 2021

Would you mind making a pull request? I like your idea.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Jun 28, 2021

sure (I don't mind).

@2bndy5 2bndy5 mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a note about possible builtin pkg
2 participants
@tannewt @2bndy5